Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90437
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 57309 invoked from network); 10 Jan 2016 03:33:31 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 10 Jan 2016 03:33:31 -0000
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.181 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 209.85.160.181 mail-yk0-f181.google.com  
Received: from [209.85.160.181] ([209.85.160.181:34344] helo=mail-yk0-f181.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id E8/D5-14657-A01D1965 for <internals@lists.php.net>; Sat, 09 Jan 2016 22:33:31 -0500
Received: by mail-yk0-f181.google.com with SMTP id a85so323233101ykb.1
        for <internals@lists.php.net>; Sat, 09 Jan 2016 19:33:30 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:from:date:message-id:subject:to:content-type;
        bh=2LNY4894C388dQ/td8i3+rP4RjUidXVxFEoGChbYt3o=;
        b=tHdxBe5sXzRS7E+15nK/kPvNa6poKaIL6Cod50sJRNCmcpFuTR7Q5Up4MdWcrKX4fA
         rEoAwmtaWbTBa8nHcCdCWurKUMFpjTqjQ8KMRmDFf+WqdpH17/q0QeR/6OlxdiW/FNu7
         Kq5piY4Nl77e9y1GRF0mZOTmGRqiyYZ8Vt1RKUYL0+cVeC4ljmXvhBlKhDjMI71Su0Sq
         +uBImxgsesVtNRTLsPrqsbuM8Lgy2iyNuhGhtSBhvtTX060Y3PoWTrrw2lv+3pAPT1Sm
         T6NplXaRnL2E3Ro6d4qttOllT8fhAlI5n4wFjZbXlZJT0vkGHWIpbF5dO6sNUFpdEdlu
         7LXw==
X-Received: by 10.13.216.71 with SMTP id a68mr65402823ywe.0.1452396807508;
 Sat, 09 Jan 2016 19:33:27 -0800 (PST)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.129.88.139 with HTTP; Sat, 9 Jan 2016 19:32:48 -0800 (PST)
Date: Sun, 10 Jan 2016 12:32:48 +0900
X-Google-Sender-Auth: 6iAlJN6BTt1bq76p2P8wwOXL3tU
Message-ID: <CAGa2bXZPUcO+u4CQsnbvCoALejkiN4WguO70PL80NK9OW-+1hA@mail.gmail.com>
To: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Fixing bug #71038 session_start() returns TRUE on failure
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi all,

I made PR
https://github.com/php/php-src/pull/1721

for bug #71038
https://bugs.php.net/bug.php?id=71038

Currently, the patch is written as it should and
breaks compatibility on PHP 5.6.

To be compatible with PHP 5.6 (PHP 7.0 is OK),
it may ignore read failures returned from save handlers.

If nobody cares current buggy logic, I would like to change
the PR to ignore read errors and commit it.

Any comments?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net