Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90382
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.172 as permitted sender)
To: Dan Ackroyd <danack@basereality.com>,
 Rowan Collins <rowan.collins@gmail.com>
References: <CADZXHp6UA4iH6196vN_U+rLSu1Tw+EazQod2LVgwJ7kkUCTd7Q@mail.gmail.com>
 <CA+kxMuQkV=OP2Wt9V6DnebMoBgy6aUf3NmZTDPo_yXXAG5N=Yw@mail.gmail.com>
 <568FDA4B.60005@gmail.com>
 <CA+kxMuRc=ZZuZqY3hrR=14hBrLfSNJ8E8hUbOvp6xe-eyzGU5Q@mail.gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Message-ID: <568FFE13.2010304@gmail.com>
Date: Fri, 8 Jan 2016 10:21:07 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CA+kxMuRc=ZZuZqY3hrR=14hBrLfSNJ8E8hUbOvp6xe-eyzGU5Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Deprecation of the Error Control Operator (@ symbol)
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> $counts[$item] ?? $counts[$item] = 1 ?? $counts[$item]++;

This looks completely unreadable and I do not think it works:
https://3v4l.org/PlAHH
Seems to leave $counts as 1 always. But even if it didn't, I would never
pass that on code review - it is very hard to understand what's going on
and it is incredibly easy to break it. Doing such stuff is definitely
not the solution, if you hate @, then if() is way better, at least it's
clear.

> $item = new StdClass;
> @$counts[$item] = "This is a bad use of error suppression.";
> 
> There is no insertion, because arrays don't support object keys. The
> operation completly failed and so there should be an exception.

No, there should not. If somebody tries to count garbage, I just don't
want to count it. I don't care about it, it's garbage.

> Currently that code fails silently.

And that is exactly what I want it to do. Sometimes silent failure is
*good*, I don't want to know about every little thing that could go
wrong, I just want what's right to be done.
Of course, your intent may be the opposite - but that's exactly the
point, there's more than one use case.
-- 
Stas Malyshev
smalyshev@gmail.com