Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90362
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.160.172 cause and error)
MIME-Version: 1.0
In-Reply-To: <568FDA4B.60005@gmail.com>
References: <CADZXHp6UA4iH6196vN_U+rLSu1Tw+EazQod2LVgwJ7kkUCTd7Q@mail.gmail.com>
	<CA+kxMuQkV=OP2Wt9V6DnebMoBgy6aUf3NmZTDPo_yXXAG5N=Yw@mail.gmail.com>
	<568FDA4B.60005@gmail.com>
Date: Fri, 8 Jan 2016 16:26:49 +0000
Message-ID: <CA+kxMuRc=ZZuZqY3hrR=14hBrLfSNJ8E8hUbOvp6xe-eyzGU5Q@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Deprecation of the Error Control Operator (@ symbol)
From: danack@basereality.com (Dan Ackroyd)

On 8 January 2016 at 15:48, Rowan Collins <rowan.collins@gmail.com> wrote:
>
> It doesn't do anything to help Stas's example for instance:
>
> @$counts[$item]++;

I think that that code is bogus since the release of PHP 7, which made
it trivial to not use the error suppression for this case, while still
writing code that doesn't take up multiple lines.

$counts[$item] ?? $counts[$item] = 1 ?? $counts[$item]++;

Yes - it's a few more characters but it has another benefit:

> This is not something which should ever throw an exception,

Oh yes, it definitely should:

$item = new StdClass;
@$counts[$item] = "This is a bad use of error suppression.";

There is no insertion, because arrays don't support object keys. The
operation completly failed and so there should be an exception.
Currently that code fails silently.

> I think it would be perfectly reasonable to implement a new file handling API, which behaves like
> modern PHP (objects, exceptions, etc) rather than being a thin wrapper for C
>
> I would also contend that a correctly thrown exception should never be
> something you want to just suppress

I very much look forward to seeing your proposal for this file
handling API, which is both easy to use, and never throws exceptions
which people will want to discard.

cheers
Dan