Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90351
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEYWF=6dvT44UcuP4JxQsw4Kx4_sUrdFD3b8Otbtbe_KtGMANg@mail.gmail.com>
References: <CAEYWF=7Px5LWGdGqHdmVwt_tWd-XAUhZzUFoOa_rDmtpi88BAA@mail.gmail.com>
	<CAF+90c_T7KZPy3h-yiak+09NZMF7UR9h8fjc-E-Vf7btFfBnLw@mail.gmail.com>
	<CAEYWF=6A4mpS5Y1KU+jZzU9hyS=ViysS_O6_5p6vMb8zmQHgvQ@mail.gmail.com>
	<5687FEC0.8010103@gmail.com>
	<CAEYWF=6dvT44UcuP4JxQsw4Kx4_sUrdFD3b8Otbtbe_KtGMANg@mail.gmail.com>
Date: Fri, 8 Jan 2016 15:39:25 +0100
Message-ID: <CAF+90c9nn9MQoZ237VUHwG+Jx8woawuUCJpY4ORJ4wkTtw9qDw@mail.gmail.com>
To: Bishop Bettini <bishop@php.net>
Cc: Rowan Collins <rowan.collins@gmail.com>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11482e78c77fd60528d38d76
Subject: Re: [PHP-DEV] [RFC] On-Demand Name Mangling
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11482e78c77fd60528d38d76
Content-Type: text/plain; charset=UTF-8

On Mon, Jan 4, 2016 at 5:16 PM, Bishop Bettini <bishop@php.net> wrote:

> On Sat, Jan 2, 2016 at 11:45 AM, Rowan Collins <rowan.collins@gmail.com>
> wrote:
>
>> On 02/01/2016 03:09, Bishop Bettini wrote:
>>
>>> But, even without a setting, there's an escape hatch: userland can
>>> polyfill
>>> the mangling behavior using extract.  The updated RFC demonstrates an
>>> algorithm.
>>>
>>
>> I'm not that comfortable with requiring / encouraging the use of
>> extract() - a rather awkward function which clobbers your local variable
>> space in unpredictable ways - to write the polyfill. The fact that the
>> clobbering is necessary / useful for extract() is wholly unrelated to the
>> need for BC in super-global arrays.
>>
>> It would be more useful to expose a method or regex constant to userland
>> so that the mangling can actually be done in place on appropriate arrays:
>>
>
> I've updated the on-demand name mangling RFC
> <https://wiki.php.net/rfc/on_demand_name_mangling> in light of all
> feedback so far.  The crux being:
>
>    - If an app requires name mangling:
>       - As of 7.1, the app will get one E_NOTICE per startup warning of
>       the impending removal of name mangling
>       - As of 8.0, the app will need to include a polyfill package and
>       add one line of code to its bootstrap.  (Safe to include the polyfill prior
>       to the release of 8.0.)
>    - If an app does not need name mangling, there's no effect, no
>    notices, nothing needed
>
> Thanks!
>

I still don't like this part:

> As written, one can't: the engine emits the error as soon as it mangles a
variable, at most one time per startup. While that's annoying, it's also
informative: someone's hitting your application in a way that may not
expect.

Even if it's only a single deprecation warning instead of multiple, it's
still a deprecation warning that I, as the application author, have
absolutely no control over. For me, a deprecation warning indicates that
there is some code I must change to make that warning *go away*.

Sure, it's informative. But it's enough to be informative about this
*once*, rather than every time a user makes an odd-ish request.

If we don't want to introduce an ini setting (against which there are good
reasons, as you have outlined) I'd just mark this as deprecated with a nice
red box in the documentation and upgrading guide, and commit to dropping it
in 8.0, but not throw actual deprecation notices.

Nikita

--001a11482e78c77fd60528d38d76--