Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90152
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.215.47 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <77.F6.12097.81D2C865@pb1.pair.com>
References: <CAESVnVoJBRF3VfKrnWGNCah3KAbxwjacPAwR1HZUC-T-vN=KDQ@mail.gmail.com>
	<77.F6.12097.81D2C865@pb1.pair.com>
Date: Tue, 5 Jan 2016 13:01:59 -0800
Message-ID: <CAESVnVq7y=czxG9B33bb6h+tTGz2DD4+w3aqyVo3w=J3+symrA@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Re: [RFC] Normalize token_get_all() output (with flag)
From: pollita@php.net (Sara Golemon)

On Tue, Jan 5, 2016 at 12:52 PM, Andrea Faulds <ajf@ajf.me> wrote:
> This is more of a side-note, but maybe it's worth bringing up. Since
> token_get_all gives an array with subarrays of a regular structure, might it
> be worthwhile returning an array of objects instead? It would probably
> reduce memory usage (assuming they're objects of a Token class or something,
> not StdClass), but I don't know if it's that useful.
>
Is the internal memory usage of (new stdClass) actually less than
(array())?  I know array changed a lot with PHP7, and that the kind of
array we're talking about here is a mixed (which would be the least
efficient), but I don't have the numbers to hand.

To your question, I'm cool either way.  Though if memory/efficiency is
a concern, returning an iterator would be even better, especially on
large files.  Though I think that's beyond the scope of this
particular RFC.

Maybe I should keep up my "1 RFC per day" run and suggest
TOKEN_ITERATOR as yet another flag....   Maybe not.  My inbox hurts.

-Sara