Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90143
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.215.42 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <568C1C1C.7040109@gmail.com>
References: <CADZXHp6UA4iH6196vN_U+rLSu1Tw+EazQod2LVgwJ7kkUCTd7Q@mail.gmail.com>
	<CAESVnVq0RK-q0UQaqOpEg2=rEwW5znp7d_EoeHLoOsigvM77Sg@mail.gmail.com>
	<4F.0A.12097.24FFB865@pb1.pair.com>
	<CAESVnVr2uMOjnTUhcL7b03-Nh4H+z1c5NttF=ykP5DFMmdHHgg@mail.gmail.com>
	<CAH-PCH5gcWZSae7D1YcB501himD1QOjy7FUGm_4ebjTT-DPofQ@mail.gmail.com>
	<568C1C1C.7040109@gmail.com>
Date: Tue, 5 Jan 2016 11:55:48 -0800
Message-ID: <CAESVnVpf8kZUZhqJO5kZ59sthnC_+RMJ4LVxmUvdgr_siHEt4w@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Deprecation of the Error Control Operator (@ symbol)
From: pollita@php.net (Sara Golemon)

On Tue, Jan 5, 2016 at 11:40 AM, Rowan Collins <rowan.collins@gmail.com> wrote:
>> @ changes the error_reporting() level for that particular call, so those
>> custom error handler won't throw exceptions for the suppressed errors but
>> when you remove/nop @ their code would throwing stuff left and right.
>
>
> I'm lost - how does this validate the claim that building scream mode into
> core would lead to problems? We already have an ini setting which can change
> the error_reporting level, so any error handler relying on that is *already*
> subject to different behaviour in different environments. Any codebase which
> wants to ignore the settings of the environment would surely already omit
> that boilerplate, and thus be unaffected by the presence or functionality of
> the @ operator.
>
Because no matter how high your error_reporting is set (globally,
per-dir, or ini-set) the @ suppression operator temporarily resets it
to zero.  In psuedo-code the following two blocks are equivalent:

@foo();

if (ini_get('scream')) {
  $old_reporting = error_reporting(0);
}
foo();
if (ini_get('scream')) {
  error_reporting($old_reporting);
}

So the argument being made is that being able to disable @ suppression
means ignoring whatever value the developer/admin has set for
error_reporting.

-Sara (not taking a stand on whether that's a compelling argument,
just clarifying it)