Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90082
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain rouvenwessling.de from 80.241.60.212 cause and error)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
In-Reply-To: <CA+kxMuQd1GUyCprFh-TwwwbZDVNkFW_j4WszBvnxpdPfsKkE=A@mail.gmail.com>
Date: Tue, 5 Jan 2016 11:39:29 +0100
Cc: Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <1C17901F-7B7C-4B89-8F87-C849AB3D7510@rouvenwessling.de>
References: <FA48561F-5D24-4CF1-A84E-78DF32A1E0A3@rouvenwessling.de> <CA+kxMuQd1GUyCprFh-TwwwbZDVNkFW_j4WszBvnxpdPfsKkE=A@mail.gmail.com>
To: Dan Ackroyd <danack@basereality.com>
Subject: Re: [PHP-DEV] RFC: Deprecate mb_ereg_replace eval option
From: me@rouvenwessling.de (=?utf-8?Q?Rouven_We=C3=9Fling?=)

Hi Dan,

> On 04 Jan 2016, at 20:52, Dan Ackroyd <danack@basereality.com> wrote:
>=20
> Are the wrong functions are listed in this sentence: "Emit an
> E_DEPRECATED error whenever mb_ereg_replace_callback or
> mb_eregi_replace_callback is called with the e option." As the RFC is
> meant to be about mb_ereg_replace, mb_eregi_replace right?

Indeed. Thanks for spotting it.

> The RFC doesn't say what functions people should use in place of the
> deprecated functions. This needs to be laid out clearly. I can guess
> what should happen for mb_ereg_replace, but there's not clear
> replacement for mb_eregi_replace, as there is no
> "mb_eregi_replace_callback" function. That ought to be thought about
> and added to the RFC.

That information is the section "Backward Incompatible Changes=E2=80=9D, =
which admittedly may not be the most obvious place to look. To quote =
that section:

=E2=80=9CThe suggested replacement, mb_ereg_replace_callback is has only =
been available since PHP 5.4.1. Projects which support both PHP 5.3 and =
PHP 7.1 may need two code paths to avoid deprecation warnings.

There is no mb_eregi_replace_callback function. Code using it will have =
to be converted to use mb_ereg_replace_callbackwith the i option."

>> The mandatory discussion period will end January 19th.
>=20
> That sentence is implying that you will put it to the vote as soon as
> possible. Please don't do that.  There is no rush to deprecate these
> functions; the earliest they would actually be removed is years away,
> and there needs to be a path guiding the people on how to replace that
> functionality in place before we deprecate them.

The implication wasn=E2=80=99t my attention. It was mostly a reminder =
for myself how long I have to keep the discussion open. That said, I =
hope this isn=E2=80=99t controversial due to the similar RFC about =
pre_replace passing 4 years ago.

Best regards
Rouven=