Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90043
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain icicle.io designates 199.38.81.6 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
In-Reply-To: <CAEYWF=7pdYc5okZim9_2Xin=djydvRYmCknA0-z9EViFQ1c-0A@mail.gmail.com>
Date: Mon, 4 Jan 2016 20:52:43 -0600
Cc: PHP internals <internals@lists.php.net>,
 Stanislav Malyshev <smalyshev@gmail.com>,
 Junade Ali <mjsa@junade.com>,
 Andrea Faulds <ajf@ajf.me>
Content-Transfer-Encoding: quoted-printable
Message-ID: <4A04F9B5-C87B-4D4C-BCA4-1CD9F49AC4A0@icicle.io>
References: <CADZXHp6UA4iH6196vN_U+rLSu1Tw+EazQod2LVgwJ7kkUCTd7Q@mail.gmail.com> <568599AA.4090209@gmail.com> <CAEYWF=7pdYc5okZim9_2Xin=djydvRYmCknA0-z9EViFQ1c-0A@mail.gmail.com>
To: bishop@php.net
Subject: Re: [PHP-DEV] Deprecation of the Error Control Operator (@ symbol)
From: aaron@icicle.io (Aaron Piotrowski)

Hi Bishop,


> On Dec 31, 2015, at 3:48 PM, Bishop Bettini <bishop@php.net> wrote:
>=20
> I am -1 on removing @ for 7.x series.  But, I would be in favor of all
> changes that remove unnecessary error messages or add functionality to
> better work with error messages. In my mind, those are requisite steps
> before removing @.
>=20

I am also very much in agreement with this. There are many conditions =
where a warning or other error is raised with no way to test for the =
condition that will trigger the error. Before the @ can be removed, =
either these errors need to be removed or they need to become an =
exception that can be caught. For example, I have the following code for =
writing to a non-blocking stream (assume $resource is a stream socket =
resource and $data is a string):

// Error reporting suppressed since fwrite() emits E_WARNING if the pipe =
is broken or the buffer is full.
$written =3D @fwrite($resource, $data);
if (false =3D=3D=3D $written) {
    $message =3D 'Failed to write to stream.';
    if ($error =3D error_get_last()) {
        $message .=3D sprintf(' Errno: %d; %s', $error['type'], =
$error['message']);
    }
    throw new FailureException($message);
}

There is no way of knowing if the stream buffer is full before calling =
fwrite(), resulting in a warning and 0 being returned. IMO, just 0 =
should be returned without issuing a warning.

Aaron Piotrowski
https://trowski.com
@trowski2002