Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90024
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lange.demon.co.uk from 91.221.168.50 cause and error)
To: internals@lists.php.net
References: <5686641B.5020209@lange.demon.co.uk>
 <E5.C5.07292.6E7AA865@pb1.pair.com>
Message-ID: <568B11AF.5070806@lange.demon.co.uk>
Date: Tue, 5 Jan 2016 00:43:27 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <E5.C5.07292.6E7AA865@pb1.pair.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: Additional Rounding modes for the round() function
From: mark@lange.demon.co.uk (Mark Baker)

On 04/01/2016 17:12, Andrea Faulds wrote:
> Hi Mark,
>
> Mark Baker wrote:
>> I'd like to suggest a couple of additional options for the round()
>> function, two new flags for PHP_ROUND_UP and PHP_ROUND_DOWN; which are
>> similar to the existing ceil() and floor() functions, but allow a
>> precision argument as well.
>>
>> The PR is at https://github.com/php/php-src/pull/1658
>>
>
> This seems like a sensible addition. That said, I'm not sure about 
> those names, I think they might get confused with 
> PHP_ROUND_HALF_UP/DOWN. Perhaps name them PHP_ROUND_CEIL and 
> PHP_ROUND_FLOOR, or so? Or PHP_ROUND_ALWAYS_UP/DOWN?
>
Thanks for the feedback.

I see where you're coming from, though I'd chosen to use 
PHP_ROUND_UP/DOWN precisely because of the two existing constants 
PHP_ROUND_HALF_UP/DOWN to provide a degree of naming consistency. That 
being said, it's simple enough to change the names of new flag 
constants; but I'll wait a couple of days to see if anybody else weighs 
in with an opinion before updating the PR.

-- 
Mark Baker

  _________
|.  \     \-3
|_J_/ PHP |
|| |  __  |
|| |m|  |m|

  I LOVE PHP