Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90018
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.173 as permitted sender)
To: Sara Golemon <pollita@php.net>, PHP internals <internals@lists.php.net>
References: <CAESVnVoJBRF3VfKrnWGNCah3KAbxwjacPAwR1HZUC-T-vN=KDQ@mail.gmail.com>
Message-ID: <568B0C84.7060802@gmail.com>
Date: Mon, 4 Jan 2016 16:21:24 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAESVnVoJBRF3VfKrnWGNCah3KAbxwjacPAwR1HZUC-T-vN=KDQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Normalize token_get_all() output (with flag)
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> https://wiki.php.net/rfc/token-get-always-tokens
> 
> This should be pretty non-controversial.  I hope?

No way!
Just kidding :) I think it's a great idea, token_get_all() is annoying
to deal with. We'd have to fix token_name though so that this would
still work:

foreach ($tokens as $token) {
    if (is_array($token)) {
        echo "Line {$token[2]}: ", token_name($token[0]), "
('{$token[1]}')", PHP_EOL;
    }
}

We could, of course, do something like
$token[0]<=255?$token[0]:token_name($token[0]) - but that looks hacky.
-- 
Stas Malyshev
smalyshev@gmail.com