Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90001
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.160.194 cause and error)
MIME-Version: 1.0
In-Reply-To: <FA48561F-5D24-4CF1-A84E-78DF32A1E0A3@rouvenwessling.de>
References: <FA48561F-5D24-4CF1-A84E-78DF32A1E0A3@rouvenwessling.de>
Date: Mon, 4 Jan 2016 19:52:32 +0000
Message-ID: <CA+kxMuQd1GUyCprFh-TwwwbZDVNkFW_j4WszBvnxpdPfsKkE=A@mail.gmail.com>
To: =?UTF-8?Q?Rouven_We=C3=9Fling?= <me@rouvenwessling.de>
Cc: Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC: Deprecate mb_ereg_replace eval option
From: danack@basereality.com (Dan Ackroyd)

Hi Rouven,

On 4 January 2016 at 16:46, Rouven We=C3=9Fling <me@rouvenwessling.de> wrot=
e:

> I=E2=80=99d like to propose the following RFC to you https://wiki.php.net=
/rfc/deprecate_mb_ereg_replace_eval_option
>
> The mandatory discussion period will end January 19th.


Are the wrong functions are listed in this sentence: "Emit an
E_DEPRECATED error whenever mb_ereg_replace_callback or
mb_eregi_replace_callback is called with the e option." As the RFC is
meant to be about mb_ereg_replace, mb_eregi_replace right?


The RFC doesn't say what functions people should use in place of the
deprecated functions. This needs to be laid out clearly. I can guess
what should happen for mb_ereg_replace, but there's not clear
replacement for mb_eregi_replace, as there is no
"mb_eregi_replace_callback" function. That ought to be thought about
and added to the RFC.


> The mandatory discussion period will end January 19th.

That sentence is implying that you will put it to the vote as soon as
possible. Please don't do that.  There is no rush to deprecate these
functions; the earliest they would actually be removed is years away,
and there needs to be a path guiding the people on how to replace that
functionality in place before we deprecate them.

Additionally, people should be given time to respond with feedback.

cheers
Dan