Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89966
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender)
To: internals@lists.php.net
References: <CAEYWF=7Px5LWGdGqHdmVwt_tWd-XAUhZzUFoOa_rDmtpi88BAA@mail.gmail.com>
 <CAF+90c_T7KZPy3h-yiak+09NZMF7UR9h8fjc-E-Vf7btFfBnLw@mail.gmail.com>
 <CAEYWF=6A4mpS5Y1KU+jZzU9hyS=ViysS_O6_5p6vMb8zmQHgvQ@mail.gmail.com>
Message-ID: <5687FEC0.8010103@gmail.com>
Date: Sat, 2 Jan 2016 16:45:52 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <CAEYWF=6A4mpS5Y1KU+jZzU9hyS=ViysS_O6_5p6vMb8zmQHgvQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] On-Demand Name Mangling
From: rowan.collins@gmail.com (Rowan Collins)

On 02/01/2016 03:09, Bishop Bettini wrote:
> But, even without a setting, there's an escape hatch: userland can polyfill
> the mangling behavior using extract.  The updated RFC demonstrates an
> algorithm.

I'm not that comfortable with requiring / encouraging the use of 
extract() - a rather awkward function which clobbers your local variable 
space in unpredictable ways - to write the polyfill. The fact that the 
clobbering is necessary / useful for extract() is wholly unrelated to 
the need for BC in super-global arrays.

It would be more useful to expose a method or regex constant to userland 
so that the mangling can actually be done in place on appropriate arrays:

$old_get = $_GET;
$_GET = [];
foreach ( $old_get as $old_key => $value ) {
$new_key = preg_replace(PHP_ILLEGAL_NAME_REGEX, '_', $old_key);
$_GET[$new_key] = $value;
}


Regards,

-- 
Rowan Collins
[IMSoP]