Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:89880 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 90359 invoked from network); 23 Dec 2015 20:41:32 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Dec 2015 20:41:32 -0000 Authentication-Results: pb1.pair.com header.from=lester@lsces.co.uk; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=lester@lsces.co.uk; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.204 cause and error) X-PHP-List-Original-Sender: lester@lsces.co.uk X-Host-Fingerprint: 217.147.176.204 mail4.serversure.net Linux 2.6 Received: from [217.147.176.204] ([217.147.176.204:45726] helo=mail4.serversure.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E6/98-51216-BF60B765 for ; Wed, 23 Dec 2015 15:41:32 -0500 Received: (qmail 31633 invoked by uid 89); 23 Dec 2015 20:41:29 -0000 Received: by simscan 1.3.1 ppid: 31627, pid: 31630, t: 0.0871s scanners: attach: 1.3.1 clamav: 0.96/m:52/d:10677 Received: from unknown (HELO ?10.0.0.7?) (lester@rainbowdigitalmedia.org.uk@81.138.11.136) by mail4.serversure.net with ESMTPA; 23 Dec 2015 20:41:29 -0000 To: internals@lists.php.net References: <002501d13bfc$23a30a60$6ae91f20$@belski.net> <5679248A.9070402@lsces.co.uk> <233DAB71-15AD-4A86-8D97-5F299AFD3B14@gmail.com> <567A8B89.5010301@lsces.co.uk> Message-ID: <567B06F8.7070607@lsces.co.uk> Date: Wed, 23 Dec 2015 20:41:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <567A8B89.5010301@lsces.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] ext/interbase maintanance From: lester@lsces.co.uk (Lester Caine) On 23/12/15 11:54, Lester Caine wrote: >> However, there are some test fails, which I am not quite sure about. > I'll work through the 5 make test failures later, but suspect it will > just be reply formats. OK nothing particularly heavy on the failures. Actually it's mainly due to the 'non-real-world' nature of the tests using combinations of connections one should never use in practice. It is not normal practice to create and delete new databases from any application when using Firebird. One would normally be working with data stored long term, so some of the problems are due to trying to delete a database that is still being created asynchronously. The ibtest.php script works with one of the existing demo databases so only relies on a stable link. That said, I think there is a leak of some sort, or rather not clearing down properly which is the error in both 004.phpt and 005.phpt Both give an 'invalid statement handle' which did not make sense initially since the same ibase_query() had been run before and after without an error. The problem is where the same variable is used a second time, after the first use has been cleared down. For example ... 004.phpt line 31 creates $q ... Line 60 reuses it without a problem, but line 102 creates the 'invalid statement handle' warning. Changing that handle from $q to $r moves the warning to line 112 which I've changed to $s and the test now runs clean. ( line numbers for .php copy of test) OK ... cross checking that it would seem that the problem is with ibase_free_result() which I think should actually free the statement handle? If I try an unset() before the next use, it's the unset which gets the warning, then the actual query runs clean. Any pointers where I should dig next? Will dig into the actual code now I know where to start ... I think. -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk