Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89877
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <233DAB71-15AD-4A86-8D97-5F299AFD3B14@gmail.com>
References: <002501d13bfc$23a30a60$6ae91f20$@belski.net> <CABBJUpfFpocd7dT2-yg1Fyq0LXU9o5txfvR_KaTP6wTOGZ8qLg@mail.gmail.com>
 <5679248A.9070402@lsces.co.uk> <233DAB71-15AD-4A86-8D97-5F299AFD3B14@gmail.com>
Date: Wed, 23 Dec 2015 13:31:20 +0800
Message-ID: <CABBJUpeMNrALQN6zm2e+JVawfQ++x6quWh5XN-nP0fNDiEmMUA@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Cc: Lester Caine <lester@lsces.co.uk>
Content-Type: multipart/alternative; boundary=001a1144071a59c18e05278a0903
Subject: Re: [PHP-DEV] ext/interbase maintanance
From: laruence@gmail.com (Xinchen Hui)

--001a1144071a59c18e05278a0903
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hey:


On Tue, Dec 22, 2015 at 7:41 PM, Xinchen Hui <laruence@gmail.com> wrote:

> Hey=EF=BC=9A
>
> Sent from my iPhone
>
> > On Dec 22, 2015, at 18:23, Lester Caine <lester@lsces.co.uk> wrote:
> >
> > On 22/12/15 08:43, Xinchen Hui wrote:
> >>> Here is a working patch of mine:
> >> https://gist.github.com/laruence/f3af903012902818d7da
> >>
> >> if you are going to work on this, please base on this one.
> >>
> >> since I still don't have setup a evn to test it... so there might be
> some
> >> problems
> >>
> >> thanks
> >
> > Xinchen ... working test setup should be easy, but I'm more than happy
> > to run tests, my problem is the core code has changed so drastically
> > since I ACTUALLY did bug fixes at that level that I don't understand th=
e
> > current methods :(
> >
> > I can understand this new patch but I still need to back-pedal the old
> > one. The only bit I'm not quite following is the switching between
> > 'NULL' and '0' as I'm not sure why you are switching to '0' for some
> > handles that are currently 'NULL' and then defaulting others which were
> > '0' to 'NULL'  but I think it's that we are now passing a pointer rathe=
r
> > than a handle?
> >
> complier wanrning about handle are int
>
> Anyway, this patch is not finish,  I hope I can finish this whole work in
> this week
>
> Will update here when it is done
>
Consider it done.

No compiler warnings anymore(expect the char* and ISC_UCHAR* mismatch)

However, there are some test fails, which I am not quite sure about.

Anyone who is faimilar with firebird, please help

https://gist.github.com/laruence/f3af903012902818d7da

thanks

>
> Thanks
> > I need to re-sync my repository with git.php.net then at least I can
> > track and roll back changes ... I'll get back to this later
> >
> > --
> > Lester Caine - G8HFL
> > -----------------------------
> > Contact - http://lsces.co.uk/wiki/?page=3Dcontact
> > L.S.Caine Electronic Services - http://lsces.co.uk
> > EnquirySolve - http://enquirysolve.com/
> > Model Engineers Digital Workshop - http://medw.co.uk
> > Rainbow Digital Media - http://rainbowdigitalmedia.co.uk
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/

--001a1144071a59c18e05278a0903--