Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89871
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLvPGaypT3++3f5HTGaui9X8mHpr7CaLuW+5oACfK6Soig@mail.gmail.com>
References: <CA+9eiLvPGaypT3++3f5HTGaui9X8mHpr7CaLuW+5oACfK6Soig@mail.gmail.com>
Date: Tue, 22 Dec 2015 19:54:45 +0300
Message-ID: <CA+9eiLt_4orzNV3fTBgkz+1YKZqmA4G32RvqXMdurw90JzebdA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>, Bob Weinand <bobwei9@hotmail.com>, 
	Xinchen Hui <xinchen.h@zend.com>, Anatol Belski <ab@php.net>, Julien Pauli <jpauli@php.net>, 
	Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e0149d05e7fd70605277f7640
Subject: Re: Removing weird error message
From: dmitry@zend.com (Dmitry Stogov)

--089e0149d05e7fd70605277f7640
Content-Type: text/plain; charset=UTF-8

It looks like the problem is a bit more complex.
The messed test Zend/tests/bug70083.phpt shows it.
My patch removes the error message, and it starts to work without errors
and warnings (I suppose we should have a warning)
Please ignore the patch before we found a consistent solution.

Thanks. Dmitry.

On Tue, Dec 22, 2015 at 7:16 PM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi,
>
> Please take a look into the patch (for master)
>
> https://gist.github.com/dstogov/44a3f2df71de31986d4c
>
> It removes weird error message and replaces it with silent handling after
> warning message. This makes engine behavior more consistent. Engine uses
> this "silent handling after warning" for many other different errors. e.g.
>   - Attempt to modify property of non-object
>   - Illegal offset type
>   - Cannot add element to the array as the next element is already occupied
>   - Cannot use a scalar value as an array
>   - This object doesn't support property references
>
> This error message was introduced by Bob by
> f57cb13c566613eec0e1c2f6d96d18565436a9b7 commit.
>
> Do anybody object against removing this error message in master?
>
> Should it be removed in PHP-5.6 and PHP-7.0 as well?
>
> Thanks. Dmitry.
>

--089e0149d05e7fd70605277f7640--