Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:89867 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71705 invoked from network); 22 Dec 2015 10:23:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Dec 2015 10:23:13 -0000 Authentication-Results: pb1.pair.com header.from=lester@lsces.co.uk; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=lester@lsces.co.uk; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 217.147.176.204 cause and error) X-PHP-List-Original-Sender: lester@lsces.co.uk X-Host-Fingerprint: 217.147.176.204 mail4.serversure.net Linux 2.6 Received: from [217.147.176.204] ([217.147.176.204:48207] helo=mail4.serversure.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 27/2B-51216-09429765 for ; Tue, 22 Dec 2015 05:23:13 -0500 Received: (qmail 5340 invoked by uid 89); 22 Dec 2015 10:23:06 -0000 Received: by simscan 1.3.1 ppid: 5334, pid: 5337, t: 0.0881s scanners: attach: 1.3.1 clamav: 0.96/m:52/d:10677 Received: from unknown (HELO ?10.0.0.7?) (lester@rainbowdigitalmedia.org.uk@81.138.11.136) by mail4.serversure.net with ESMTPA; 22 Dec 2015 10:23:06 -0000 To: internals@lists.php.net References: <002501d13bfc$23a30a60$6ae91f20$@belski.net> Message-ID: <5679248A.9070402@lsces.co.uk> Date: Tue, 22 Dec 2015 10:23:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] ext/interbase maintanance From: lester@lsces.co.uk (Lester Caine) On 22/12/15 08:43, Xinchen Hui wrote: >> Here is a working patch of mine: > https://gist.github.com/laruence/f3af903012902818d7da > > if you are going to work on this, please base on this one. > > since I still don't have setup a evn to test it... so there might be some > problems > > thanks Xinchen ... working test setup should be easy, but I'm more than happy to run tests, my problem is the core code has changed so drastically since I ACTUALLY did bug fixes at that level that I don't understand the current methods :( I can understand this new patch but I still need to back-pedal the old one. The only bit I'm not quite following is the switching between 'NULL' and '0' as I'm not sure why you are switching to '0' for some handles that are currently 'NULL' and then defaulting others which were '0' to 'NULL' but I think it's that we are now passing a pointer rather than a handle? I need to re-sync my repository with git.php.net then at least I can track and roll back changes ... I'll get back to this later -- Lester Caine - G8HFL ----------------------------- Contact - http://lsces.co.uk/wiki/?page=contact L.S.Caine Electronic Services - http://lsces.co.uk EnquirySolve - http://enquirysolve.com/ Model Engineers Digital Workshop - http://medw.co.uk Rainbow Digital Media - http://rainbowdigitalmedia.co.uk