Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89799
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADajX4D4e0edK9ytxwhRp1rh4QXDanj4kj=3EF6+cvB0uOPSUQ@mail.gmail.com>
References: <CALtfysYKe46Obma=ZzAoH6xDzguogT2RvsgUy-GyWyCpxA=vgg@mail.gmail.com>
	<CADajX4D4e0edK9ytxwhRp1rh4QXDanj4kj=3EF6+cvB0uOPSUQ@mail.gmail.com>
Date: Thu, 10 Dec 2015 18:29:47 +0100
Message-ID: <CALtfysb-9o_5Jp3foGEdVQPANFTEaE=_oJe=pg-FP8wKgx_rVw@mail.gmail.com>
To: Adam Harvey <aharvey@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bfceb00ad062805268e8ddb
Subject: Re: [PHP-DEV] Converting an 'old' PHP 5.x extension to PHP 7
From: sjoerd.maessen@gmail.com (Sjoerd Maessen)

--047d7bfceb00ad062805268e8ddb
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Jan, Fran=C3=A7ois and Adam,

Thank you for the quick responses. Ah yes an extension name can be helpful.
I=E2=80=99m talking about the extension =E2=80=9Cphp-svm=E2=80=9D of Ian Ba=
rber (
https://github.com/ianbarber/php-svm) which I made a fork of
https://github.com/sjoerdmaessen/php-svm

Regards,
Sjoerd

On Thu, Dec 10, 2015 at 6:22 PM, Adam Harvey <aharvey@php.net> wrote:

> On 10 December 2015 at 08:51, Sjoerd Maessen <sjoerd.maessen@gmail.com>
> wrote:
> > As a first time poster I'm very nervous but here we go!
>
> Welcome!
>
> > I cloned the github repo and was able to remove 1 error during the
> > compilation process that had to do with ZVAL_STRING. This was an easy
> error
> > to fix since it came down to simply removing an argument. I've read
> > https://wiki.php.net/phpng-upgrading but still I feel like there should
> be
> > more resources available after seeing the amount of extensions that are
> > already successfully converted for PHP 7. For example I'm now stuck how
> to
> > fix an error like:
> >
> > "error: too many arguments to function =E2=80=98zend_hash_get_current_k=
ey_ex=E2=80=99"
>
> We don't really have comprehensive documentation of how internal APIs
> have changed from 5 to 7. Beyond the things noted on the phpng and
> phpng-upgrading pages on the wiki, the best resource is probably
> lxr.php.net, where you can look up a definition on both the PHP-5.6
> and PHP-7.0 branches and see how they've changed.
>
> For the most part, extension API changes are largely around things
> like removing indirection on zvals, HashTables now containing zvals
> rather than void pointers, and strings being represented as
> zend_string structs rather than paired char * and int pointers.
>
> > How can I continue with making this work? Any good (up-to-date)
> resources?
> > An IRC channel where I can help?
>
> There is #php.pecl on efnet =E2=80=94 it's not the highest traffic channe=
l,
> but if you're patient there'll generally be someone around who can
> help.
>
> Adam
>

--047d7bfceb00ad062805268e8ddb--