Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89798
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
Sender: adam@adamharvey.name
In-Reply-To: <CALtfysYKe46Obma=ZzAoH6xDzguogT2RvsgUy-GyWyCpxA=vgg@mail.gmail.com>
References: <CALtfysYKe46Obma=ZzAoH6xDzguogT2RvsgUy-GyWyCpxA=vgg@mail.gmail.com>
Date: Thu, 10 Dec 2015 09:22:30 -0800
Message-ID: <CADajX4D4e0edK9ytxwhRp1rh4QXDanj4kj=3EF6+cvB0uOPSUQ@mail.gmail.com>
To: Sjoerd Maessen <sjoerd.maessen@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Converting an 'old' PHP 5.x extension to PHP 7
From: aharvey@php.net (Adam Harvey)

On 10 December 2015 at 08:51, Sjoerd Maessen <sjoerd.maessen@gmail.com> wro=
te:
> As a first time poster I'm very nervous but here we go!

Welcome!

> I cloned the github repo and was able to remove 1 error during the
> compilation process that had to do with ZVAL_STRING. This was an easy err=
or
> to fix since it came down to simply removing an argument. I've read
> https://wiki.php.net/phpng-upgrading but still I feel like there should b=
e
> more resources available after seeing the amount of extensions that are
> already successfully converted for PHP 7. For example I'm now stuck how t=
o
> fix an error like:
>
> "error: too many arguments to function =E2=80=98zend_hash_get_current_key=
_ex=E2=80=99"

We don't really have comprehensive documentation of how internal APIs
have changed from 5 to 7. Beyond the things noted on the phpng and
phpng-upgrading pages on the wiki, the best resource is probably
lxr.php.net, where you can look up a definition on both the PHP-5.6
and PHP-7.0 branches and see how they've changed.

For the most part, extension API changes are largely around things
like removing indirection on zvals, HashTables now containing zvals
rather than void pointers, and strings being represented as
zend_string structs rather than paired char * and int pointers.

> How can I continue with making this work? Any good (up-to-date) resources=
?
> An IRC channel where I can help?

There is #php.pecl on efnet =E2=80=94 it's not the highest traffic channel,
but if you're patient there'll generally be someone around who can
help.

Adam