Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89581
Return-Path: <martin.keckeis1@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 71548 invoked from network); 3 Dec 2015 16:21:40 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 3 Dec 2015 16:21:40 -0000
Authentication-Results: pb1.pair.com header.from=martin.keckeis1@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=martin.keckeis1@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.175 as permitted sender)
X-PHP-List-Original-Sender: martin.keckeis1@gmail.com
X-Host-Fingerprint: 209.85.217.175 mail-lb0-f175.google.com  
Received: from [209.85.217.175] ([209.85.217.175:33393] helo=mail-lb0-f175.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 25/EB-02069-31C60665 for <internals@lists.php.net>; Thu, 03 Dec 2015 11:21:40 -0500
Received: by lbbkw15 with SMTP id kw15so4752065lbb.0
        for <internals@lists.php.net>; Thu, 03 Dec 2015 08:21:36 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=9GXCzNLXxthKC4+PpzF/E/uipXvofNOsH5lOZGDRi+Y=;
        b=yLSXLCNZ2Z6gNaQ+1bGqZwTCYaVj+5dRRrp0UGy0/RJpvgbi0/69ukN+jamXxpixFH
         pmo1X2PtuOCRJZvLlItoFi1xrLmjxO2KzMrPNEWBrnEIiMYSF6gudTuPvT9giP6GTuhp
         RDav6oZofJmNy6P1EGe1zyBL8i7PCrHMh2cGgXrrUV5TpDR66dm3fE3ceutYBsxbrLn7
         WkAsYFf+lUXDmRdA6RmvjKFMuDmXJp4yE0HnhduGPYLCO8CDXyOdfRJg2BEow1P8Nb5X
         ZKXcUmqGkwWZC2Y1G55nTRQ0zrCWcZDl6Hn9YcJmTHrTiJ9zVwIwya3paZVhyZj/1U15
         /eww==
MIME-Version: 1.0
X-Received: by 10.112.119.133 with SMTP id ku5mr5868307lbb.1.1449159696729;
 Thu, 03 Dec 2015 08:21:36 -0800 (PST)
Received: by 10.25.21.27 with HTTP; Thu, 3 Dec 2015 08:21:36 -0800 (PST)
In-Reply-To: <CAEZPtU7QcPG55g2ixSjkio29Oxk7=5ZnX6s9yV66HKnVsSsdwg@mail.gmail.com>
References: <CAEp07h9q8G0goVAvjLW+ah25YpHhuV_F26o0KkT+k+Y4sHUa+g@mail.gmail.com>
	<08E52A39-9EF8-42C0-9C72-FB2AA0CBC604@zend.com>
	<CAEZPtU7QcPG55g2ixSjkio29Oxk7=5ZnX6s9yV66HKnVsSsdwg@mail.gmail.com>
Date: Thu, 3 Dec 2015 17:21:36 +0100
Message-ID: <CAEp07h8oq1L8NdmOzkePCMcVMkWwgQEmGk7PjcnyeSWhb3Gmcg@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Zeev Suraski <zeev@zend.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7bb040cef24f30052600c872
Subject: Re: [PHP-DEV] Remove get_browser() from core
From: martin.keckeis1@gmail.com (Martin Keckeis)

--047d7bb040cef24f30052600c872
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

2015-12-03 14:38 GMT+01:00 Pierre Joye <pierre.php@gmail.com>:

>
> On Dec 3, 2015 8:32 PM, "Zeev Suraski" <zeev@zend.com> wrote:
> >
> >
> > > On 2 =D7=91=D7=93=D7=A6=D7=9E=D7=B3 2015, at 9:52, Martin Keckeis <ma=
rtin.keckeis1@gmail.com>
> wrote:
> > >
> > > Hello together,
> > >
> > > i think it's time to deprecate the function get_browser().
> > >
> >
> > +1.  Would be nice if we could point to a recommended alternative in th=
e
> deprecation message.
>
> +1 too.
> Hard to do it in the error message but there are plenty of tools doing a
> far better jobs using log analysis (for the stats).
>
> Cheers,
> Pierre
>
A message would really be good.

But get_browser() is a bit special, since it returns the "browser
capabilities" which only this type of parser can do.
So the "dropin" replacement would be
https://github.com/browscap/browscap-php

I will soon publish a new check with >1000k user agents analyzed by 9
different parsers out there...will notice you if it's done.

Best regards
Martin

--047d7bb040cef24f30052600c872--