Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89580
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20151203154644.GA61092@3006.local>
References: <20151020173602.GA92318@3006.local>
	<CA+9eiLtkVHWa323DENMXG+uAQmTGdnpL1wo=6izXn0=UOGuZBQ@mail.gmail.com>
	<20151203154644.GA61092@3006.local>
Date: Thu, 3 Dec 2015 19:09:18 +0300
Message-ID: <CA+9eiLvX0MhCsv+3jdgD2Bb_MBmoijdzWKidcA0kYB-SQnuDDA@mail.gmail.com>
To: Sean DuBois <sean@siobud.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e013a0026fa9cf60526009c42
Subject: Re: [PHP-DEV] [RFC] [VOTE] Class Constant Visibility
From: dmitry@zend.com (Dmitry Stogov)

--089e013a0026fa9cf60526009c42
Content-Type: text/plain; charset=UTF-8

OK. thanks. I'll try to find time to do this on next week.
In any case I'll give a chance to review the future patch.
Somebody might get other good improvement ideas and we don't have to hurry
now :)

Thanks. Dmitry.

On Thu, Dec 3, 2015 at 6:46 PM, Sean DuBois <sean@siobud.com> wrote:

> Hi Dmitry!
> Thanks for the quickly reply.
>
> That is a bummer that the patch isn't gonna work! But yes, please go
> ahead and take it on! You don't have to show me the PR (I am happy with
> what ever you choose to do). There are some
> tests so once every passes I will be excited to see it merge :)
>
> On Thu, Dec 03, 2015 at 12:29:50PM +0300, Dmitry Stogov wrote:
> > Hi Sean,
> >
> > Although the RFC is accepted, the patch has to be significantly reworked.
> > Probably, it's going to be better and faster if I do it myself.
> > Let me know, if you are agree (I'll do this when I have time, and show
> you
> > PR before commit).
> >
> > Thanks. Dmitry.
> >
> > On Tue, Oct 20, 2015 at 8:36 PM, Sean DuBois <sean@siobud.com> wrote:
> >
> > > Hey list,
> > >
> > > Time for a simple RFC (in theory)!
> > >
> > > I would like to add visibility modifiers to class constants, and then
> > > as a nice added bonus give more info from the Reflection API (constants
> > > now are a dedicated class so nice things like doc comments)
> > >
> > > https://wiki.php.net/rfc/class_const_visibility
> > >
> > > thanks!
> > >
> > > --
> > > PHP Internals - PHP Runtime Development Mailing List
> > > To unsubscribe, visit: http://www.php.net/unsub.php
> > >
> > >
>

--089e013a0026fa9cf60526009c42--