Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:89505 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 13153 invoked from network); 1 Dec 2015 08:49:18 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 1 Dec 2015 08:49:18 -0000 Authentication-Results: pb1.pair.com smtp.mail=remi@fedoraproject.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=remi@fedoraproject.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.198 cause and error) X-PHP-List-Original-Sender: remi@fedoraproject.org X-Host-Fingerprint: 217.70.183.198 relay6-d.mail.gandi.net Received: from [217.70.183.198] ([217.70.183.198:52582] helo=relay6-d.mail.gandi.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 81/64-13465-C0F5D565 for ; Tue, 01 Dec 2015 03:49:17 -0500 Received: from mfilter38-d.gandi.net (mfilter38-d.gandi.net [217.70.178.169]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id 3327EFBA46 for ; Tue, 1 Dec 2015 09:49:14 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter38-d.gandi.net Received: from relay6-d.mail.gandi.net ([IPv6:::ffff:217.70.183.198]) by mfilter38-d.gandi.net (mfilter38-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id TQRhsPLIsvbu for ; Tue, 1 Dec 2015 09:49:12 +0100 (CET) X-Originating-IP: 82.241.130.121 Received: from schrodingerscat.famillecollet.com (pom51-2-82-241-130-121.fbx.proxad.net [82.241.130.121]) (Authenticated sender: contact@ll-experts.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D3595FBA39 for ; Tue, 1 Dec 2015 09:49:11 +0100 (CET) To: PHP Internals References: <565CD9E2.7030501@gmail.com> <01d101d12bd7$a44f79d0$ecee6d70$@belski.net> Message-ID: <565D5F07.1020205@fedoraproject.org> Date: Tue, 1 Dec 2015 09:49:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <01d101d12bd7$a44f79d0$ecee6d70$@belski.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] HashDos protection From: remi@fedoraproject.org (Remi Collet) Le 01/12/2015 02:28, Anatol Belski a écrit : >From what I was testing, the configuration is not absolutely necessary. My first thinking, seeing this hardcoded limit was also, "we need to make it an new ini option". So I run a few tests. Especially the Anatol one (a bit optimized to get more unique keys faster), and with a debug message in zend_hash.c to display max number of collisions encountered during the run After some time... With around 9.2 millions of unique keys, and ~1.2GB of memory used, the max collisions never exceeds "12". So I really think, now, that we can go without new ini option. Remi.