Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89503
Return-Path: <smalyshev@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 81415 invoked from network); 30 Nov 2015 23:21:14 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 30 Nov 2015 23:21:14 -0000
Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.50 as permitted sender)
X-PHP-List-Original-Sender: smalyshev@gmail.com
X-Host-Fingerprint: 209.85.220.50 mail-pa0-f50.google.com  
Received: from [209.85.220.50] ([209.85.220.50:33006] helo=mail-pa0-f50.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 70/30-13465-8E9DC565 for <internals@lists.php.net>; Mon, 30 Nov 2015 18:21:13 -0500
Received: by pabfh17 with SMTP id fh17so205492901pab.0
        for <internals@lists.php.net>; Mon, 30 Nov 2015 15:21:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=subject:to:references:from:message-id:date:user-agent:mime-version
         :in-reply-to:content-type:content-transfer-encoding;
        bh=cHXg3T/EZ0lpmR9mY2Il6oTvo6SummpqCXIwf6c0zyM=;
        b=GpNsRxQZFM7zZwDJIh038r/5IMcoh2gzhxUy2yY0BKB85sG4PZhcM8FSgFSnHVyetJ
         f6jnMWM6BTo6PrbX7ss1Qrx6UOIS14rPpAaTQ4hZcY4uJZafYA2SFLVs/jr3Cw4jiYCE
         k6dHF1iwbx4Gj7NiS4cOr0gmNwfreMCRAFDSAS65sTVZKd2HFVl8o36CWUK7M9xm6OHF
         ZcuoxGz4Gw+DqAH+7pOs5JKUmLgC66SXLMTgJCREMxjVv9HXOGwg8nBqv4vcq2KdZ5a/
         Fqr4pXNatFm83OGXtHq2DYVbC0ZNIYHADuP1mrEKRHb2LFkdOCUu5Qe0OVYaO4jF2xw3
         rc9g==
X-Received: by 10.98.7.129 with SMTP id 1mr75314091pfh.70.1448925670153;
        Mon, 30 Nov 2015 15:21:10 -0800 (PST)
Received: from Stas-Air.local ([2602:304:cdc2:e5f0:2dee:b8a8:8454:c2e9])
        by smtp.gmail.com with ESMTPSA id x79sm53390010pfi.47.2015.11.30.15.21.08
        (version=TLSv1/SSLv3 cipher=OTHER);
        Mon, 30 Nov 2015 15:21:08 -0800 (PST)
To: Nikita Popov <nikita.ppv@gmail.com>,
 PHP internals <internals@lists.php.net>,
 Anatol Belski <anatol.php@belski.net>, Remi Collet <remi@php.net>
References: <CAF+90c_pVFVbzqThuPg1V3VDTV-7Ci4O6T6hNtY5XPgVb2Mt-Q@mail.gmail.com>
X-Enigmail-Draft-Status: N1110
Message-ID: <565CD9E2.7030501@gmail.com>
Date: Mon, 30 Nov 2015 15:21:06 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAF+90c_pVFVbzqThuPg1V3VDTV-7Ci4O6T6hNtY5XPgVb2Mt-Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] HashDos protection
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> To fix the HashDos vulnerability for *all* cases (rather than just GET/POST
> parsing), I propose to introduce collision counting during hashtable
> insertion operations. This will throw a fatal error if the number of
> collisions during an insertion operation exceed a certain threshold.
> 
> Implementation: https://github.com/php/php-src/pull/1565

This looks pretty cool. I'd support making the limit configurable
though, is there a reason why it's not?

-- 
Stas Malyshev
smalyshev@gmail.com