Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:89459 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 3655 invoked from network); 27 Nov 2015 07:19:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 27 Nov 2015 07:19:52 -0000 Authentication-Results: pb1.pair.com smtp.mail=remi@fedoraproject.org; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=remi@fedoraproject.org; sender-id=unknown Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.194 cause and error) X-PHP-List-Original-Sender: remi@fedoraproject.org X-Host-Fingerprint: 217.70.183.194 relay2-d.mail.gandi.net Received: from [217.70.183.194] ([217.70.183.194:54501] helo=relay2-d.mail.gandi.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BC/64-04444-61408565 for ; Fri, 27 Nov 2015 02:19:51 -0500 Received: from mfilter19-d.gandi.net (mfilter19-d.gandi.net [217.70.178.147]) by relay2-d.mail.gandi.net (Postfix) with ESMTP id BA0A0C5B23 for ; Fri, 27 Nov 2015 08:19:43 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter19-d.gandi.net Received: from relay2-d.mail.gandi.net ([IPv6:::ffff:217.70.183.194]) by mfilter19-d.gandi.net (mfilter19-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id GdaC5JqakWTd for ; Fri, 27 Nov 2015 08:19:42 +0100 (CET) X-Originating-IP: 82.241.130.121 Received: from schrodingerscat.famillecollet.com (pom51-2-82-241-130-121.fbx.proxad.net [82.241.130.121]) (Authenticated sender: contact@ll-experts.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 966BCC5DD2 for ; Fri, 27 Nov 2015 08:16:57 +0100 (CET) To: PHP Internals References: Message-ID: <5658035F.9040604@fedoraproject.org> Date: Fri, 27 Nov 2015 08:16:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: HashDos protection From: remi@fedoraproject.org (Remi Collet) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Le 26/11/2015 18:24, Nikita Popov a écrit : > Here is an implementation of this mechanism for PHP: > https://github.com/php/php-src/pull/1565 > > This is the approach I would recommend for PHP. The patch for this > change is small and non-intrusive and does not break ABI. From my > testing it has no adverse performance impact. (In microbenchmarks > I found it to even be consistently faster, as it uses a more > specialized implementation for a commonly used type of insertion > operation.) Thanks for this work. I agree, this seems a very acceptable solution, I would also recommend it, even for 7.0.1 (perhaps even for 5.6 if possible) Remi. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlZYA18ACgkQYUppBSnxahg7pQCeNCpRjQxdzZz9MXF94snPsigB nxwAn0lK0VAZgn5u4n+S1C1ABlvRrRWU =otYB -----END PGP SIGNATURE-----