Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89405
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c-yNEBMfftZjptnjAwbmz2BMHPzNzQQahZjB362HLdhAQ@mail.gmail.com>
References: <56547DFE.3080407@php.net> <C8.C9.57156.EB494565@pb1.pair.com>
 <565496FA.2010604@gmail.com> <84.DA.57156.C6B94565@pb1.pair.com>
 <56549E24.7030902@gmail.com> <E3.FB.57156.853A4565@pb1.pair.com>
 <5654BAE2.8020306@beccati.com> <BLU436-SMTP16582A5115915883CC3DAF2E2060@phx.gbl>
 <CABBJUpeUwbtwMmNpwz=YTj4zkEE-OGJ7uuC2=8hK2t_w+tdPVA@mail.gmail.com> <CAF+90c-yNEBMfftZjptnjAwbmz2BMHPzNzQQahZjB362HLdhAQ@mail.gmail.com>
Date: Wed, 25 Nov 2015 19:10:12 +0800
Message-ID: <CABBJUpdiNMJ+C9J9o7BdeyRdV60zYoBEgAt3SvQPJwJT1DenjQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Bob Weinand <bobwei9@hotmail.com>, Anatol Belski <anatol@belski.net>, Andrea Faulds <ajf@ajf.me>, 
	Matteo Beccati <php@beccati.com>, internals PHP <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114402deb6717605255b817e
Subject: Re: [PHP-DEV] Scalar Type Declaration Syntax Weirdness
From: laruence@php.net (Xinchen Hui)

--001a114402deb6717605255b817e
Content-Type: text/plain; charset=UTF-8

Hey:

On Wed, Nov 25, 2015 at 5:57 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Wed, Nov 25, 2015 at 4:47 AM, Xinchen Hui <laruence@php.net> wrote:
>
>> Hey:
>>
>>
>>
>> On Wed, Nov 25, 2015 at 4:49 AM, Bob Weinand <bobwei9@hotmail.com> wrote:
>>
>> > > Am 24.11.2015 um 20:30 schrieb Matteo Beccati <php@beccati.com>:
>> > >
>> > > On 24/11/2015 18:50, Andrea Faulds wrote:
>> > >> There's no syntax change. We'd be adding another fatal error to
>> > >> zend_compile.c triggered by a flag on the token. No messing around
>> with
>> > >> the parser.
>> > >>
>> > >> I understand your concern about the risk, but it's the kind of change
>> > >> that wouldn't break anything without it being tremendously obvious.
>> > >
>> > > I agree and we should be still in time for RC8.
>> > >
>> > >
>> > > Cheers
>> > > --
>> > > Matteo Beccati
>> >
>> > Hey,
>> >
>> > I fixed the issue via
>> >
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=569763cb1ac67f56e7743062ca8b3b7c650c1254
>> >
>> > I think too this should go into PHP 7.0.0 as it is some type of a
>> language
>> > related change (even if not directly failing in parser...)
>> >
>> >
>> I've made a improvement to the fix(
>>
>> https://github.com/php/php-src/commit/00865ae22f2c5fdee9e500ce79d442467e0a0899
>> )
>> ,
>>
>> before this, \array will result a syntax , but \int result a compiler
>> error, which seems a little in-consistent.
>>
>
> Imho this additional change is not necessary, it only makes the parser
> more complicated.
>
> However something missing from the original patch is handling of relative
> names like namespace\int. Instead of checking for ast->attr == ZEND_NAME_FQ
> it should check for ast->attr != ZEND_NAME_NOT_FQ.
>

PS: However, namespace\int will result error while checking valid
classname, as int is reserved keywords.

so I think check for == ZEND_NAME_FQ is enough here.

thanks

>
>

>
> Nikita
>



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/

--001a114402deb6717605255b817e--