Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89323
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.50 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <EFB1D7E4-C594-4F15-A6A0-5D8344BA8F79@lerdorf.com>
References: <CAAyV7nG9E-7STWq2Hpe=y5Uf0nWzGMhka+FUX1p1FVNtYNVTJQ@mail.gmail.com>
 <112FFBCD-8445-40BC-B92F-3A97D3E97C4C@zend.com> <CAAyV7nE0bQba3Wr2yi8FbtDfDA=8ZSFz9dbQG5uZ+eF9bick2A@mail.gmail.com>
 <56523F74.9040708@lerdorf.com> <06a601d125c0$99d5cfd0$cd816f70$@belski.net>
 <CAL=_i_kArsu2JGYtdZBa-mah+k6DL-cCWtiX16mVcTsxH3WDrw@mail.gmail.com>
 <CABBJUpdTUwvdtK+uRc386R4pceocXCsSEd9s4bu4jvH87MD-8A@mail.gmail.com>
 <CABDNdAG84+cW9TohGbA2r0ik5=yrHVyAd5g2wk8dKRh=LeqvPQ@mail.gmail.com>
 <5652D782.40601@lerdorf.com> <F037E7ED-B9B0-47DD-9B42-4EEC2B267118@php.net> <EFB1D7E4-C594-4F15-A6A0-5D8344BA8F79@lerdorf.com>
Date: Mon, 23 Nov 2015 12:21:40 +0100
Message-ID: <CAMUwpuQ_1Nsyj3tV_=QZBnwQ6tq-iNegRX+9xYXOsQneNVd=sg@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: Derick Rethans <derick@php.net>, Phil Sturgeon <pjsturgeon@gmail.com>, Xinchen Hui <laruence@php.net>, 
	Joe Watkins <pthreads@pthreads.org>, Anatol Belski <anatol.php@belski.net>, 
	Anthony Ferrara <ircmaxell@gmail.com>, Zeev Suraski <zeev@zend.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] INDRECT in arrays causes count() to become unpredictable
From: jpauli@php.net (Julien Pauli)

On Mon, Nov 23, 2015 at 11:17 AM, Rasmus Lerdorf <rasmus@lerdorf.com> wrote=
:
> On Nov 23, 2015, at 10:35, Derick Rethans <derick@php.net> wrote:
>>
>>> On November 23, 2015 10:08:18 AM GMT+01:00, Rasmus Lerdorf <rasmus@lerd=
orf.com> wrote:
>>>> On 11/23/2015 09:49 AM, Phil Sturgeon wrote:
>>>> The "There will always be bugs" argument is a strawman, nobody is
>>>> saying wait until it's perfect.
>>>>
>>>> People in this thread are consistently conflating "there will always
>>>> be bugs" with "lets just ignore this bug which is 'around critical'
>>>> and crack on because yolo."
>>>
>>> You seem to be confused Phil. Nobody is arguing that this bug shouldn't
>>> be fixed. The question is all about how severe it is and whether it
>>> should trigger another release candidate.
>>
>> Do I understand that you'd like to release 7.0.0 as 7.0.0RC7 + the count=
 fix on Thursday?
>
> Yes
>
>> I don't think we should push out 7.0.0 without the count fix, but I also=
 don't think it warrants another RC.
>>
>> If people think it needs another RC, then perhaps do one on Thu 26th wit=
h just RCA+ count fix, plus final on Thu Dec 3rd?
>
> I am ok with either. I don't think the count fix is destabilizing enough =
to warrant another RC. The fix seems simple and localized to me, but either=
 people are confused, or they genuinely feel strongly enough that this is i=
ndicative of further problems and another RC will provide us with more time=
 to find similar issues or perhaps just give everyone a sense of confidence=
 in the release.
>
> There is also the fact that a lot of us are in Paris this week and and at=
 least some of us will be in transit on the 26th so a one-week delay might =
be a good idea for that reason alone.

I'am balanced.

We discovered a bug, we have a fix , the fix is easy, self contained,
reviewed by many eyes.

So, we have all we need for a GA now, this week, no ?

Pushing another RC is all right, but if we find new bugs in this RC,
some that could be critical, then we'll postpone GA to January,
because we'll then fall in mid-December, etc...

We all have eyes, we all can spot bugs whenever we want to. Why another RC =
now ?
With another RC, we have time to concentrate on the code, OK, but we
still have this time if we are in GA, as we'll have anyway a 7.0.1
coming shortly after...


I'm not really +1 for another RC this week, but better for a GA. But
that's my opinion...


Julien.P