Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89263
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <564B09A4.3050706@gmail.com>
References: <CABHuAWzi5n_5k_7QNLQNwYuD+xxWN9OcJsz28ED4OB=MVZuLCQ@mail.gmail.com>
	<564A547C.9060504@garfieldtech.com>
	<564A629C.9040709@rochette.cc>
	<564A69C1.5080208@garfieldtech.com>
	<2D.66.34372.2A78A465@pb1.pair.com>
	<564B09A4.3050706@gmail.com>
Date: Tue, 17 Nov 2015 11:19:47 +0000
Message-ID: <CABHuAWxtqBCcehvZwZSLH-sen=QVgXqYBu9-ygdp7bv+Ss9o_w@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1145bd101272560524bab458
Subject: Re: [PHP-DEV] Immutable modifier
From: t.carnage@gmail.com (Chris Riley)

--001a1145bd101272560524bab458
Content-Type: text/plain; charset=UTF-8

On 17 November 2015 at 11:04, Rowan Collins <rowan.collins@gmail.com> wrote:

> Hi Andrea,
>
> Andrea Faulds wrote on 17/11/2015 01:47:
>
>> Larry Garfield wrote:
>>
>>> The "everything in the constructor" is the problem.  That results in,
>>> essentially, an obscenely long function call that just happens to be
>>> named __construct().  If I wanted something that obscure and hard to
>>> work with I'd just use anonymous arrays. :-)
>>>
>>
>> Huh?
>>
>> "with" methods and __construct are not exclusive. In fact, you could have
>> a private constructor and only have "with" methods. Only allowing
>> assignment to properties in the constructor doesn't prevent having a nice
>> API: have your methods call the constructor.
>>
>> I don't see what you're getting at here.
>>
>>
> Making the "with" methods wrap the constructor tidies the public API, but
> that (private) constructor needs to be just as complex as Larry said
> earlier - you've got to manually extract all the properties of one
> instance, and pass them as parameters to the other. Or, you could copy them
> one by one inside the body of the constructor, which comes to the same
> thing - lots of boilerplate.
>
> If you look at the PSR-7 implementation I linked to earlier [1], there's
> no such boilerplate, just a single call to "clone $this", and PHP does it
> all for you. But that doesn't work with a simplistic definition of
> immutable like "mutable in constructor" or "mutable until non-null"; you
> need to be able to "freeze" an instance once you've set it up, or have
> privileged (private) methods which are allowed to mutate the properties.
>
> [1] https://github.com/guzzle/psr7/blob/master/src/Request.php#L101
>
> Regards,
> --
> Rowan Collins
> [IMSoP]
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
Could clone take an array parameter of immutable property overrides?

$copied = clone ($immutable, ['foo' => 'bar']);

--001a1145bd101272560524bab458--