Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89195
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <8368447.U2fgg7TetA@mcmic-probook>
References: <3187501.to7rK1FKUl@mcmic-probook>
	<CAEYWF=69goSpbPM6P_vwgwQwNddJynKrOmnUaV0AhFHB0ddcSw@mail.gmail.com>
	<CAH-PCH58fYRfP2s54ddeZYThdqWRgZYuj_dTvcYWvO1JDuFGAg@mail.gmail.com>
	<8368447.U2fgg7TetA@mcmic-probook>
Date: Thu, 12 Nov 2015 09:39:52 +0100
Message-ID: <CAH-PCH7v6mjJYH0ZV-s7Bt36BTU=2YCpYvbonqq-0WkuhMNifw@mail.gmail.com>
To: =?UTF-8?Q?C=C3=B4me_Chilliet?= <come@opensides.be>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11443cb4f435d6052453e27b
Subject: Re: [PHP-DEV] One last ldap_connect headache
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a11443cb4f435d6052453e27b
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 12, 2015 at 7:09 AM, C=C3=B4me Chilliet <come@opensides.be> wro=
te:

> Le vendredi 6 novembre 2015, 11:43:58 Ferenc Kovacs a =C3=A9crit :
> >
> > on the other hand functions like ftp_connect assumes the default port
> when
> > passed NULL:
> >
> > I'm fine with changing this for future versions but my understanding is
> > that this BC break (along with some others) was introduced in a micro
> > release (5.6.11 afair), so at least for 5.6 I would prefer restoring th=
e
> > old behavior and for 7.0 I'm fine with the change but please document i=
t
> in
> > NEWS and UPGRADING so we can incorporate it in the docs.
> >
>
> Ok, so I pushed a fix to treat NULL (and 0 for that matter, same as in
> ftp_connect) into the default ldap port.
> I pushed only to 5.6 as I think for 7 we should keep the error, it does
> not makes much sense to accept NULL as port and the documentation does no=
t
> mention it.
>
> MCMic
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
thanks!

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a11443cb4f435d6052453e27b--