Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:89194 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33044 invoked from network); 12 Nov 2015 06:10:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Nov 2015 06:10:47 -0000 Authentication-Results: pb1.pair.com header.from=come@opensides.be; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=come@opensides.be; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain opensides.be designates 195.154.20.141 as permitted sender) X-PHP-List-Original-Sender: come@opensides.be X-Host-Fingerprint: 195.154.20.141 smtp.opensides.be Received: from [195.154.20.141] ([195.154.20.141:39676] helo=smtp.opensides.be) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 19/B6-16149-56D24465 for ; Thu, 12 Nov 2015 01:10:46 -0500 Received: from localhost (localhost [127.0.0.1]) by smtp.opensides.be (Postfix) with ESMTP id F377676D47 for ; Thu, 12 Nov 2015 07:10:43 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at opensides.be Received: from smtp.opensides.be ([127.0.0.1]) by localhost (smtp.opensides.be [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0DYyDS3HXonQ for ; Thu, 12 Nov 2015 07:10:43 +0100 (CET) Received: from mcmic-probook.localnet (node-tgj.pool-182-52.dynamic.totbb.net [182.52.149.35]) by smtp.opensides.be (Postfix) with ESMTPSA id 1743D76D46 for ; Thu, 12 Nov 2015 07:10:43 +0100 (CET) To: internals@lists.php.net Date: Thu, 12 Nov 2015 07:09:52 +0100 Message-ID: <8368447.U2fgg7TetA@mcmic-probook> Organization: OpenSides User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: References: <3187501.to7rK1FKUl@mcmic-probook> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [PHP-DEV] One last ldap_connect headache From: come@opensides.be (=?ISO-8859-1?Q?C=F4me?= Chilliet) Le vendredi 6 novembre 2015, 11:43:58 Ferenc Kovacs a =E9crit : >=20 > on the other hand functions like ftp_connect assumes the default port= when > passed NULL: >=20 > I'm fine with changing this for future versions but my understanding = is > that this BC break (along with some others) was introduced in a micro= > release (5.6.11 afair), so at least for 5.6 I would prefer restoring = the > old behavior and for 7.0 I'm fine with the change but please document= it in > NEWS and UPGRADING so we can incorporate it in the docs. >=20 Ok, so I pushed a fix to treat NULL (and 0 for that matter, same as in = ftp_connect) into the default ldap port. I pushed only to 5.6 as I think for 7 we should keep the error, it does= not makes much sense to accept NULL as port and the documentation does= not mention it. MCMic