Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89174
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.41 as permitted sender)
To: internals@lists.php.net
References: <CANUQDCh5R3dir=fzb3uGgKUrbk266BR6xWLn4Gt0-OWCOfZtAQ@mail.gmail.com>
 <alpine.DEB.2.20.1511091643530.14376@whisky.home.derickrethans.nl>
 <72.8B.21426.C9492465@pb1.pair.com> <op.x7wy4qw4twp9n2@charlie>
Message-ID: <56431F2D.4010601@gmail.com>
Date: Wed, 11 Nov 2015 10:57:49 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <op.x7wy4qw4twp9n2@charlie>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Null bytes in anonymous class names
From: rowan.collins@gmail.com (Rowan Collins)

Steven Hilder wrote on 11/11/2015 02:13:
> This behaviour was present in Joe's original implementation, but later
> removed[3] by Nikita. His commit message says that this was "dead 
> code", but
> I don't see what was wrong with it. 

It looks to me like 'decl->name' will never be set for an anonymous 
class, so the old code was just passing a null into 
zend_name_anon_class(), which is pointless (hence "dead" code, i.e. 
"unreachable").

I guess what it should have been passed (maybe was in previous 
revisions) was extends_name, which is only extracted from the AST much 
further down the function. 
http://git.php.net/?p=php-src.git;a=blob;f=Zend/zend_compile.c;hb=HEAD#l5315