Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89090
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFi=QfZDo2y7ZMRJSe2haFOAOeU8rmoaBOqZ=M-J0Hx2kBknSQ@mail.gmail.com>
References: <3187501.to7rK1FKUl@mcmic-probook>
	<58.47.13519.54409365@pb1.pair.com>
	<2499781.S8xp2TXu1I@mcmic-probook>
	<CAH-PCH5HHFySHt3oMgVR_D8yJDo5_jp_kwcuk1t-wCbh6F2KVg@mail.gmail.com>
	<563B5903.3000807@heigl.org>
	<CAH-PCH6V2xda1=Ag38_6Ur6coBcDbn_=ZJk0vsJHQTz9Q+s=wA@mail.gmail.com>
	<CAEYWF=7RHWoUrsShs0x_M7RRTjv2VGHF0Lu-ZiQBiebnZq7yYg@mail.gmail.com>
	<CAH-PCH4_JTtC+JOXsTe5nTjo5pcqDsFt30JcKx2ddefbQEexbQ@mail.gmail.com>
	<CAFi=QfZDo2y7ZMRJSe2haFOAOeU8rmoaBOqZ=M-J0Hx2kBknSQ@mail.gmail.com>
Date: Fri, 6 Nov 2015 01:07:08 +0100
Message-ID: <CAH-PCH5wge0AL4LSuM=1z7zdSH_4OpfdHN=iw2Dhszi=+1Jo9w@mail.gmail.com>
To: Adam Howard <oldschooldsl@gmail.com>
Cc: bishop@php.net, Andreas Heigl <andreas@heigl.org>, =?UTF-8?Q?C=C3=B4me_Chilliet?= <come@opensides.be>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=089e013d1f9048b76f0523d40607
Subject: Re: [PHP-DEV] Re: Small regression in PHP-LDAP
From: tyra3l@gmail.com (Ferenc Kovacs)

--089e013d1f9048b76f0523d40607
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 5, 2015 at 9:53 PM, Adam Howard <oldschooldsl@gmail.com> wrote:

> I don't think it is possible to make everyone happy all the time.  I thin=
k
> this should be kept for a user code fix.
>
>
please don't top post on the php.net mailing lists.
on one hand this change doesn't really make any person happy (apart maybe
the ext/ldap maintainers) but already caused headache for people upgrading
to a patch release and expecting their code to still work.
I don't think that it is tradeoff worth taking.

now I've just took the time to look the actual commit which break this
feature:
https://github.com/php/php-src/commit/e7af0fe1eb89e40671e86a588aa1b78607b85=
461
previously we were just passing host and port to ldap_init:
https://github.com/php/php-src/commit/e7af0fe1eb89e40671e86a588aa1b78607b85=
461#diff-baba61601f82518312197f5420a76ae7L346
and the documentation for ldap_init states that
*ldap_open()* takes *host*, the hostname on which the LDAP server is
running, and *port*, the port number to which to connect. If the default
IANA-assigned port of 389 is desired, LDAP_PORT should be specified for
*port*. The *host* parameter may contain a blank-separated list of hosts to
try to connect to, and each host may optionally by of the form *host:port*.
If present, the *:port* overrides the *port* parameter to *ldap_open()*.
http://linux.die.net/man/3/ldap_init

so this wasn't just a bogus feature but php being the glue and the
underlying library providing this feature, then when we removed the else
block to remove the usage of the now deprecated ldap_open we lost this
feature.
it would be fairly trivial to transform host:port formatted hosts to be
transformed to the new schema://host:port format required by
ldap_initialize (and ldap_is_ldap_url()) instead of just assuming that
receiving an url not validated by ldap_is_ldap_url() means that we received
a naked hostname

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--089e013d1f9048b76f0523d40607--