Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89082
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.176 as permitted sender)
To: internals@lists.php.net
References: <CANUQDCh5R3dir=fzb3uGgKUrbk266BR6xWLn4Gt0-OWCOfZtAQ@mail.gmail.com>
Message-ID: <563B6ED1.1030601@gmail.com>
Date: Thu, 5 Nov 2015 14:59:29 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CANUQDCh5R3dir=fzb3uGgKUrbk266BR6xWLn4Gt0-OWCOfZtAQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Null bytes in anonymous class names
From: rowan.collins@gmail.com (Rowan Collins)

On 05/11/2015 14:21, Niklas Keller wrote:
> Hello,
>
> I discovered today that anonymous class names contain a null byte right
> after "class@anonymous". I don't think class names should contain
> non-printable characters.
>
> How about removing that null byte?
>
> https://3v4l.org/QUKpV
>
> https://github.com/php/php-src/blob/da8e6ec4a5063d9f60f83f43c55bc17d015cac8b/Zend/zend_compile.c#L5207
>
> Regards, Niklas
>

PHP uses null bytes quite a lot to produce deliberately illegal 
identifiers. For instance the old eval-like create_function() [e.g. 
https://3v4l.org/hqHjh] and the serialization of private members [e.g. 
https://3v4l.org/R6Y6k]

In this case, I guess the "@" in "class@anonymous" makes the name 
illegal anyway, but I'm not sold on the null byte being more 
unacceptable here than anywhere else.

Regards,

-- 
Rowan Collins
[IMSoP]