Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89081
Return-Path: <leight@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 43833 invoked from network); 5 Nov 2015 14:45:12 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 5 Nov 2015 14:45:12 -0000
Authentication-Results: pb1.pair.com smtp.mail=leight@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=leight@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.170 as permitted sender)
X-PHP-List-Original-Sender: leight@gmail.com
X-Host-Fingerprint: 209.85.212.170 mail-wi0-f170.google.com  
Received: from [209.85.212.170] ([209.85.212.170:36492] helo=mail-wi0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 85/E2-24765-47B6B365 for <internals@lists.php.net>; Thu, 05 Nov 2015 09:45:09 -0500
Received: by wimw2 with SMTP id w2so11639907wim.1
        for <internals@lists.php.net>; Thu, 05 Nov 2015 06:45:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=NDONnUnxR78q7jIiOITbVATkWEx11kK1THacgLbJcZY=;
        b=la5hBw1OsRpgZwGfrlX6Dv8fKoPsHk4FsRVcfs8KoLo4zYMjub8F2pMBHjGQV984Xn
         8yuC5GksnktyvosOLE15LRjxnvy8tICbH97pxivUo592vc2nxbEsuMmn6ds5Uha5E75N
         X8pwscEQZlO55NqN+9ad5undMS0lnAj4p8XUOsh3cm86AWr66m4cmrY9yqoQ3efmooK6
         NGsqqjw2GllmpLvNa1/NjypQsepDPAdNN9Y1IhocrNP+7EMPw1uYYS6xkgDkDCMtdiY8
         85fbnVhoqY9H7iilvrxp4I/xotHXYYyZZzXVW1QANHR1ygv1NCJfre5EIm1PrV8n5Y0+
         aQoQ==
MIME-Version: 1.0
X-Received: by 10.194.143.43 with SMTP id sb11mr10206002wjb.120.1446734705896;
 Thu, 05 Nov 2015 06:45:05 -0800 (PST)
Received: by 10.28.145.200 with HTTP; Thu, 5 Nov 2015 06:45:05 -0800 (PST)
In-Reply-To: <CANUQDCh5R3dir=fzb3uGgKUrbk266BR6xWLn4Gt0-OWCOfZtAQ@mail.gmail.com>
References: <CANUQDCh5R3dir=fzb3uGgKUrbk266BR6xWLn4Gt0-OWCOfZtAQ@mail.gmail.com>
Date: Thu, 5 Nov 2015 14:45:05 +0000
Message-ID: <CAPwsocHFzcEjmbinW-HcsFenXuZrvP3YBYrfgBwJHhuh+4Dn9g@mail.gmail.com>
To: Niklas Keller <me@kelunik.com>
Cc: PHP Internals <internals@lists.php.net>, bwoebi@php.net
Content-Type: multipart/alternative; boundary=089e0112c50c3ab4f40523cc2c11
Subject: Re: [PHP-DEV] Null bytes in anonymous class names
From: leight@gmail.com (Leigh)

--089e0112c50c3ab4f40523cc2c11
Content-Type: text/plain; charset=UTF-8

On 5 November 2015 at 14:21, Niklas Keller <me@kelunik.com> wrote:

> Hello,
>
> I discovered today that anonymous class names contain a null byte right
> after "class@anonymous". I don't think class names should contain
> non-printable characters.
>
> How about removing that null byte?
>
> https://3v4l.org/QUKpV
>
>
> https://github.com/php/php-src/blob/da8e6ec4a5063d9f60f83f43c55bc17d015cac8b/Zend/zend_compile.c#L5207
>
> Regards, Niklas
>

It's also quite worrying that it is leaking memory addresses.

--089e0112c50c3ab4f40523cc2c11--