Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89076
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <2499781.S8xp2TXu1I@mcmic-probook>
References: <3187501.to7rK1FKUl@mcmic-probook>
	<58.47.13519.54409365@pb1.pair.com>
	<2499781.S8xp2TXu1I@mcmic-probook>
Date: Thu, 5 Nov 2015 14:14:54 +0100
Message-ID: <CAH-PCH5HHFySHt3oMgVR_D8yJDo5_jp_kwcuk1t-wCbh6F2KVg@mail.gmail.com>
To: =?UTF-8?Q?C=C3=B4me_Chilliet?= <come@opensides.be>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1145a800b61f910523cae906
Subject: Re: [PHP-DEV] Re: Small regression in PHP-LDAP
From: tyra3l@gmail.com (Ferenc Kovacs)

--001a1145a800b61f910523cae906
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 4, 2015 at 4:28 AM, C=C3=B4me Chilliet <come@opensides.be> wrot=
e:

> Le mardi 3 novembre 2015, 18:59:42 Andrea Faulds a =C3=A9crit :
> > I'd argue this is a regression, documented feature or not. Supporting
> > 'host:port' is not a bug, and this has broken existing code, which micr=
o
> > (x.y.Z) versions are not allowed to do. It should be fixed ASAP.
>
> So I got two votes against and one for putting host:port back.
>
> I feel bad about pissing off users that used host:port, but it does seems
> safer to require the scheme.
>
> Detecting the host:port syntax only to show a warning seems tedious. It=
=E2=80=99s
> like saying to the user =C2=ABI get what you want me to do, but I won=E2=
=80=99t do it=C2=BB.
>
> And the point that it=E2=80=99s already been gone since a few version any=
way is
> also a good point, people would have a code that works on some versions a=
nd
> not others, let=E2=80=99s save them the nightmare.
>
> After reading the reactions on the bug tickets related to this problem, i=
t
> seems users are understanding the change and adapting without problem, so
> I=E2=80=99m for fixing the documentation on this one. Discussing the deta=
ils on a
> separate email.
>
> MCMic
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
I would keep the old behavior for 5.6, even if that was unintended nobody
complained about it(so removing it isn't a bugfix per se), so I see no
reason to break userland code working before in a micro version.
for PHP-7.0 we can remove the old undocumented behavior but drop a mention
in NEWS/upgrading.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu

--001a1145a800b61f910523cae906--