Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89065
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain opensides.be designates 195.154.20.141 as permitted sender)
To: internals@lists.php.net
Date: Wed, 04 Nov 2015 05:00:38 +0100
Message-ID: <7863331.7prpVflOvN@mcmic-probook>
Organization: OpenSides
User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; )
In-Reply-To: <3187501.to7rK1FKUl@mcmic-probook>
References: <3187501.to7rK1FKUl@mcmic-probook>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Subject: Fixing ldap_connect documentation
From: come@opensides.be (=?ISO-8859-1?Q?C=F4me?= Chilliet)

Hello,

About ldap_connect documentation, we got an interesting proposition the=
re: https://github.com/owncloud/core/issues/20020#issuecomment-15338788=
6
The idea is to documment the LDAP URI version as a default and only lis=
t the host, port syntax as a backward compatibilty thing.
Which it is IMO.
The fact that when using (host, port) SSL is not supported goes strongl=
y in that direction.
http://php.net/manual/en/ldap.requirements.php already says OpenLDAP>=3D=
2.4 is needed so =C2=ABIf you are using OpenLDAP 2.x.x=C2=BB can be rem=
oved.
=20
What should be clear in the documentation=E2=80=AF:
- The LDAP URI scheme is the recommended way to call ldap_connect
- The ldap:// or ldaps:// is required
- People can use host, port if they do not need SSL
- Second parameter is not used if the first one is an LDAP scheme, so c=
alling ldap_connect('ldap://localhost', 456) will use default port 389.=


Does that seem ok?

MCMic

PS: just saw that Andreas Heigl already edited the doc, to some of it i=
s already fixed. It could still be improved to recommend LDAP URIS more=
 clearly.