Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:89063 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7996 invoked from network); 4 Nov 2015 02:26:59 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Nov 2015 02:26:59 -0000 Authentication-Results: pb1.pair.com smtp.mail=bobwei9@hotmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=bobwei9@hotmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain hotmail.com designates 65.55.116.96 as permitted sender) X-PHP-List-Original-Sender: bobwei9@hotmail.com X-Host-Fingerprint: 65.55.116.96 blu004-omc3s21.hotmail.com Received: from [65.55.116.96] ([65.55.116.96:59679] helo=BLU004-OMC3S21.hotmail.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 18/0B-13519-1FC69365 for ; Tue, 03 Nov 2015 21:26:58 -0500 Received: from BLU437-SMTP100 ([65.55.116.72]) by BLU004-OMC3S21.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Tue, 3 Nov 2015 18:26:54 -0800 X-TMN: [CL3wfNk/VHy3nuUfiU/t8hIqbA5Qtv/g] X-Originating-Email: [bobwei9@hotmail.com] Message-ID: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) In-Reply-To: Date: Wed, 4 Nov 2015 03:26:49 +0100 CC: Xinchen Hui , Dmitry Stogov , fabian@tag1consulting.com, Anatol Belski , Nikita Popov , PHP Internals Content-Transfer-Encoding: quoted-printable References: To: Paul Dragoonis X-Mailer: Apple Mail (2.3094) X-OriginalArrivalTime: 04 Nov 2015 02:26:52.0115 (UTC) FILETIME=[43F8CA30:01D116A8] Subject: Re: [PHP-DEV] Bug #70805 (Segmentation faults whilst running Drupal 8 test suite) From: bobwei9@hotmail.com (Bob Weinand) Hey, zend_vm_execute.h is an auto-generated file, via zend_vm_gen.php. In = reality the patch only fixes the code in exactly one location = (zend_vm_def.h) and then regenerated zend_vm_execute.h. Bob > Am 04.11.2015 um 03:10 schrieb Paul Dragoonis : >=20 > Hey, >=20 > Looking at the patch, the changes to zend_vm_def.h and = zend_vm_execute.h > are duplicated in 10 locations. I'm wondering if we can consolidate = this > into maintainable function/macro to handle this? >=20 > On Wed, Nov 4, 2015 at 1:58 AM, Xinchen Hui = wrote: >=20 >> Hey: >>=20 >>=20 >>=20 >> On Wed, Nov 4, 2015 at 3:58 AM, Dmitry Stogov = wrote: >>=20 >>> Hi, >>>=20 >>> I think, I found the root problem of >> https://bugs.php.net/bug.php?id=3D70805 >>>=20 >>> unset($a) or unser($GLOBAL["a"]) triggered GC and destructors calls = that >>> tried to release the same global variable $a once again. As result = it's >>> reference counter was decremented twice and this caused = use-after-free, >>> double-free, etc. >>>=20 >>> The proposed cumulative fix for all related problems: >>>=20 >>> https://gist.github.com/dstogov/7aa9d24876e2b3fce8c5 >>>=20 >>> Xinchen, could you please review and verify this once again, >>> then add necessary tests and commit. >>>=20 >> No problem, all issues we met are resovled , thanks :) >>=20 >> tested and committed. >>=20 >> and aslo thanks the fabian who provides us ssh access to a = reproducible box >> (it's really hard to reproduce locally) >>=20 >> thanks! >>=20 >>>=20 >>> Thanks. Dmitry. >>>=20 >>=20 >>=20 >>=20 >> -- >> Xinchen Hui >> @Laruence >> http://www.laruence.com/ >>=20