Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:89062 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 6105 invoked from network); 4 Nov 2015 02:10:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Nov 2015 02:10:31 -0000 Authentication-Results: pb1.pair.com header.from=dragoonis@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dragoonis@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.176 as permitted sender) X-PHP-List-Original-Sender: dragoonis@gmail.com X-Host-Fingerprint: 209.85.212.176 mail-wi0-f176.google.com Received: from [209.85.212.176] ([209.85.212.176:36175] helo=mail-wi0-f176.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 38/AA-13519-41969365 for ; Tue, 03 Nov 2015 21:10:29 -0500 Received: by wicfx6 with SMTP id fx6so80746139wic.1 for ; Tue, 03 Nov 2015 18:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=sNk053YPovqYOT0Ep8/L7+i4dwh67DcSF9EB+Dqcjtg=; b=unqmWSF6EzkBSp/MvpMXGVbWsV6Mh9wFOeW5Q1ZLw5BDmhNl7icoIU0YqLsdqTg4RY aPPJF93supeSWEmkpbFNYAxq8vDELu2Bi7qlwJEsKL1562AcA21ih1zfvqKsYh52QLaX FNReDgV0mJryJjLqu3DIhpKq6VpDK8Ki9FJKflscjF2Y91mXDsL2aUwDKtWje/Sdd8nW lv9dEWXC6JLHez21CJPMiL/E8SUD+Qh5Tl5+ShqLg52xG1qFHxT5zbo3/NfWml08KXgA c/HpM5eByXlrHZtO6mfmKSi6JXTdyu9nhQ+aB2K12/C3f9FLE5jaRdp7GTgMBiktDUkN Oavg== MIME-Version: 1.0 X-Received: by 10.194.243.102 with SMTP id wx6mr32427352wjc.68.1446603025233; Tue, 03 Nov 2015 18:10:25 -0800 (PST) Received: by 10.27.129.67 with HTTP; Tue, 3 Nov 2015 18:10:25 -0800 (PST) In-Reply-To: References: Date: Wed, 4 Nov 2015 02:10:25 +0000 Message-ID: To: Xinchen Hui Cc: Dmitry Stogov , fabian@tag1consulting.com, Anatol Belski , Nikita Popov , PHP Internals Content-Type: multipart/alternative; boundary=089e01493cfe733fb80523ad83d1 Subject: Re: [PHP-DEV] Re: Bug #70805 (Segmentation faults whilst running Drupal 8 test suite) From: dragoonis@gmail.com (Paul Dragoonis) --089e01493cfe733fb80523ad83d1 Content-Type: text/plain; charset=UTF-8 Hey, Looking at the patch, the changes to zend_vm_def.h and zend_vm_execute.h are duplicated in 10 locations. I'm wondering if we can consolidate this into maintainable function/macro to handle this? On Wed, Nov 4, 2015 at 1:58 AM, Xinchen Hui wrote: > Hey: > > > > On Wed, Nov 4, 2015 at 3:58 AM, Dmitry Stogov wrote: > > > Hi, > > > > I think, I found the root problem of > https://bugs.php.net/bug.php?id=70805 > > > > unset($a) or unser($GLOBAL["a"]) triggered GC and destructors calls that > > tried to release the same global variable $a once again. As result it's > > reference counter was decremented twice and this caused use-after-free, > > double-free, etc. > > > > The proposed cumulative fix for all related problems: > > > > https://gist.github.com/dstogov/7aa9d24876e2b3fce8c5 > > > > Xinchen, could you please review and verify this once again, > > then add necessary tests and commit. > > > No problem, all issues we met are resovled , thanks :) > > tested and committed. > > and aslo thanks the fabian who provides us ssh access to a reproducible box > (it's really hard to reproduce locally) > > thanks! > > > > > Thanks. Dmitry. > > > > > > -- > Xinchen Hui > @Laruence > http://www.laruence.com/ > --089e01493cfe733fb80523ad83d1--