Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89061
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.174 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CA+9eiLvPy_bp6djdw902i=cfaLq94-9-KDQVBWhgCYoWeWX1JA@mail.gmail.com>
References: <CA+9eiLvPy_bp6djdw902i=cfaLq94-9-KDQVBWhgCYoWeWX1JA@mail.gmail.com>
Date: Wed, 4 Nov 2015 09:58:50 +0800
Message-ID: <CABBJUpfUQSoA2JK927vJanDoUPD2_0XoJVfoTXZGs8nQxxNBug@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>, fabian@tag1consulting.com
Cc: Anatol Belski <ab@php.net>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114162c230a75a0523ad5be0
Subject: Re: Bug #70805 (Segmentation faults whilst running Drupal 8 test suite)
From: xinchen.h@zend.com (Xinchen Hui)

--001a114162c230a75a0523ad5be0
Content-Type: text/plain; charset=UTF-8

Hey:



On Wed, Nov 4, 2015 at 3:58 AM, Dmitry Stogov <dmitry@zend.com> wrote:

> Hi,
>
> I think, I found the root problem of https://bugs.php.net/bug.php?id=70805
>
> unset($a) or unser($GLOBAL["a"]) triggered GC and destructors calls that
> tried to release the same global variable $a  once again. As result it's
> reference counter was decremented twice and this caused use-after-free,
> double-free, etc.
>
> The proposed cumulative fix for all related problems:
>
> https://gist.github.com/dstogov/7aa9d24876e2b3fce8c5
>
> Xinchen, could you please review and verify this once again,
> then add necessary tests and commit.
>
No problem, all issues we met are resovled , thanks :)

tested and committed.

and aslo thanks the fabian who provides us ssh access to a reproducible box
(it's really hard to reproduce locally)

thanks!

>
> Thanks. Dmitry.
>



-- 
Xinchen Hui
@Laruence
http://www.laruence.com/

--001a114162c230a75a0523ad5be0--