Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:89007
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <E3.B0.16245.74862365@pb1.pair.com>
References: <CAFp73XuG9PfYv448muxijyk7MS5xG7J5zxz021YQPtAReYvkyQ@mail.gmail.com>
 <E3.B0.16245.74862365@pb1.pair.com>
Date: Thu, 29 Oct 2015 14:57:38 -0400
Message-ID: <CAFp73Xt+eMTAD4ohbwBKAOvaMtjPRrymWMbKtF6sLGQUXamOuw@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b33d906a43de5052342e36c
Subject: Re: [PHP-DEV] Re: Support execution scope realization at runtime (or
 last pieces forprivate class support)
From: guilhermeblanco@gmail.com ("guilhermeblanco@gmail.com")

--047d7b33d906a43de5052342e36c
Content-Type: text/plain; charset=UTF-8

Hi Andrea,

I'm very happy to see you back! You're a great contributor to PHP... =)
Sorry, I may have written in a bad form, but here is the context...

Looking at this phpt file
https://github.com/guilhermeblanco/php-src/blob/class-modifiers/Zend/tests/visibility_modifiers/namespaced_private_class_different_namespace_instantiation.phpt
It currently fails giving this error: "Fatal error: Top level scope cannot
instantiate package private class A\B in %s on line %d"
What happens is that at runtime, there is no scope definition defined when
I look for EG(scope) in the zend_vm. This means that it doesn't matter if
the code is in a top-level or inside of a namespace (but not inside of a
class/method/function), scope is always null.
This breaks the execution, because it can't correlate to the proper
namespace it's instantiating and the entire approach of restricting usage
of private classes doesn't work.
Does that make sense now? I actually detailed in all the written tests
which ones currently fail, all because of exact same situation.

My question falls back to anyone with deeper knowledge of zend_vm or
internals how and what would be necessary to finalize the patch (this is
the last missing piece as it currently stands), so I could officially
propose for discussion by everyone here.

Regards,


On Thu, Oct 29, 2015 at 2:41 PM, Andrea Faulds <ajf@ajf.me> wrote:

> Hi Guilherme,
>
> guilhermeblanco@gmail.com wrote:
>
> Currently, there's no way to determine at runtime what is the scope of the
>> execution. This means you can't resolve if the current instruction is
>> happening on a top-level scope, in a class definition, namespace, function
>> or method.
>>
>> Together with this (maybe even more importantly), there's no way to
>> resolve
>> namespaces in any way, since they only exist up to compile time (they
>> become part of class name through string append), and no real data
>> structure around it exists. I was forced to create a weird string check to
>> make it work... =(
>>
>
> Making plain string literals in function calls be interpreted differently
> depending on context does not sound like a good idea to me. Functions
> shouldn't rely on hidden (non-syntactically-obvious) contextual
> information; I think func_get_args() et al. were a mistake.
>
> I'm not sure why we'd need to resolve namespaces at runtime anyway. If you
> just need to pass the name of a class to a function, we have ::class. Is
> there some use-case I'm unaware of?
>
> Thanks.
>
> --
> Andrea Faulds
> http://ajf.me/
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
Guilherme Blanco
MSN: guilhermeblanco@hotmail.com
GTalk: guilhermeblanco
Toronto - ON/Canada

--047d7b33d906a43de5052342e36c--