Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88960
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.52 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <BLU437-SMTP80680F918D469D1EC111A0E2210@phx.gbl>
References: <CA+9eiLuVkwpTzfzJpNG_REgF=v31nWdY6BDcN8kp5oTz2eg+DA@mail.gmail.com>
 <CA+9eiLuDJf9z5Lh0_Ca8VphmoDHC=ZkNZm=j6ytg0Bvswo_V_A@mail.gmail.com> <BLU437-SMTP80680F918D469D1EC111A0E2210@phx.gbl>
Date: Wed, 28 Oct 2015 14:20:59 +0800
Message-ID: <CABBJUpc-CQttR9602O65DagNn5OHNiBnTJOi12f3LuySof7GQQ@mail.gmail.com>
To: Bob Weinand <bobwei9@hotmail.com>
Cc: Dmitry Stogov <dmitry@zend.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1143924ecd94f90523243390
Subject: Re: Speed up fetching of class entries for self:: parent:: and
 static:: (Bob's idea)
From: xinchen.h@zend.com (Xinchen Hui)

--001a1143924ecd94f90523243390
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hey:

On Wed, Oct 28, 2015 at 2:11 PM, Bob Weinand <bobwei9@hotmail.com> wrote:

>
> Am 28.10.2015 um 05:20 schrieb Dmitry Stogov <dmitry@zend.com>:
>
> What is the general impression from the patch?
> Should we commit it (with minor fixes and/or additional optimisations)?
> Bob, do you see performance improvement on your app?
>
> Thanks. Dmitry.
> On Oct 27, 2015 4:14 PM, "Dmitry Stogov" <dmitry@zend.com> wrote:
>
>> Hi,
>>
>> Please take a look: https://github.com/php/php-src/pull/1604
>> The speed improvement on real-life is insignificant.
>> VM size is increased by 10KB.
>>
>> I don't have a strong opinion, if this should go into master or not.
>>
>> Thanks. Dmitry.
>>
>
> In general I like the patch, if only for the reason that it splits up the
> monster zend_fetch_var_address_helper actually was into two helpers=E2=80=
=A6
>
> I benchmarked https://github.com/amphp/aerys/blob/master/lib/HPack.php wi=
th
> the following code:
>
> // Two example request headers from RFC 7541
> $data1 =3D hex2bin(str_replace(" ", "", "8286 8441 8cf1 e3c2 e5f2 3a6b a0=
ab
> 90f4 ff"));
> $data2 =3D hex2bin(str_replace(" ", "", "8286 84be 5886 a8eb 1064 9cbf"))=
;
>
> for ($i =3D 0; $i < 1e5; $i++) {
>     $obj =3D new HPack;
>     $obj->decode($data1);
>     $obj->decode($data2);
> }
>
> and got 6.27 vs. 6.01 seconds (4%). With the one or other optimization
> (like mentioned in PR: not doing a zend_fetch_class() on each call, maybe
> more), it'll be probably even more.
>
4% is also a significant improvement.

I 'd like to see it to be committed to master branch, we can keep do
something opts base on this after it merged.

thanks

>
> (I realize there's a lot overhead, but that's because I try to have a not
> too synthetic benchmark; but at least these methods are the bottleneck of
> most HTTP/2 traffic in this server app, so, if I can speed these up, it
> will be significant.)
>
> Bob
>



--=20
Xinchen Hui
@Laruence
http://www.laruence.com/

--001a1143924ecd94f90523243390--