Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88924
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.44 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAMUwpuSr5PP_+g9otjMsfMFFnwPz6BNG0mYzw9x+GwmsqMk-5Q@mail.gmail.com>
References: <CAF+90c_io7TG4P+=cZrMEwhv=+9PxLQDQa9fijSG7OPfoKg6hA@mail.gmail.com>
	<CA+9eiLviENrreQMHUguRYpjht=PCA4jepNWME72VA-ihZYeTTw@mail.gmail.com>
	<CAF+90c9ENiRX=U1PY1Bn48b6coqfQ6RJVYsBg_xBRjba5uRvGg@mail.gmail.com>
	<01f001d1052b$bed5cbb0$3c816310$@belski.net>
	<CAF+90c9_yMPV-vEUvXpbbcE5bGZsfJmByASsjN-=w_b6Bhk5+Q@mail.gmail.com>
	<022301d1053b$06a91a50$13fb4ef0$@belski.net>
	<CABBJUpcOGostFgX_okgZXjUxYMQC6LN80E9G6GZh0UBPnxu1rg@mail.gmail.com>
	<02c801d10588$9009fd80$b01df880$@belski.net>
	<CAEbg-4bo4Ex3H-27AOVeBt7AdXhz8Jg7xvgskVL1M2YF_BRBrg@mail.gmail.com>
	<CAF+90c-svi8Bf3Vb7saU8zm8OtDQN9zwVOv5aojgE4Y2mOMeTw@mail.gmail.com>
	<CAEbg-4bto3Bfj7PMTkD85APwfeZpiAM9ipoFPRSAr+rC_XhkQw@mail.gmail.com>
	<CAMUwpuSr5PP_+g9otjMsfMFFnwPz6BNG0mYzw9x+GwmsqMk-5Q@mail.gmail.com>
Date: Fri, 23 Oct 2015 11:57:35 +0300
Message-ID: <CAEbg-4ZQoUrOEREBo_taTXBjD50XNoWwA+CdK8Aqj+T3yZ9T7w@mail.gmail.com>
To: Julien Pauli <jpauli@php.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Anatol Belski <anatol.php@belski.net>, 
	Xinchen Hui <laruence@php.net>, Dmitry Stogov <dmitry@zend.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113fb9848cd2290522c1cdaa
Subject: Re: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()
From: lisachenko.it@gmail.com (Alexander Lisachenko)

--001a113fb9848cd2290522c1cdaa
Content-Type: text/plain; charset=UTF-8

2015-10-22 18:48 GMT+03:00 Julien Pauli <jpauli@php.net>:

> This is very tricky use case IMO.
>
> We should absolutely focus on stability, and if we can't find a way to
> make things safe, we forbid them
> for the stability sake. If there are no way to have stable things,
> well, that's pitty but it's like that.
>
> We can't allow PHP to release with a known crashing behavior.
>
> Perhaps we'll find new ways to do things in 7.1 or next 8.0.
>


Good morning! Thank you, Julien, for paying an attention to my message and
pointing to the things that are more important. I'm absolutely agree with
you that the stability of the core is priority task for now, so it will be
better to keep php7.0 core as stable as possible.

Of course, this patch introduces some BC breaks, because now code that
accepts \Closure instance should be able to check, if this instance of
closure from ReflectionFunction or not to decide about possibility of
binding. Technically they should be equal.

Today I was able to test my code with RC5 and things aren't so bad, all
main features working, except minor ones ) All dynamic methods can be
called with closures, because I only need instance rebinding for closure,
not the scope, because it's already passed as argument for
getClosure($this). Simplified example https://3v4l.org/WRuZ6. For static
methods, keeping LSB with closures is tricky, but it works via
forward_static_call_array and putting it into the closure, which can be
easily binded to the required scope: https://3v4l.org/kLN0E

So, it's not a big deal for me anymore, all other things are tricky and
aren't used very often. Thanks!

--001a113fb9848cd2290522c1cdaa--