Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88923
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.48 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CA+9eiLsuQ=K4ChvqwcrJDw3k9o7M9FGLSSphGLZQ2LCnEUe7ng@mail.gmail.com>
References: <CAKSD0w7N5B+R4YWpShF5yos-=qRN2XGo03rLjdd4mEKw=DXaJg@mail.gmail.com>
	<CA+9eiLsuQ=K4ChvqwcrJDw3k9o7M9FGLSSphGLZQ2LCnEUe7ng@mail.gmail.com>
Date: Fri, 23 Oct 2015 15:31:34 +0800
Message-ID: <CAKSD0w4wcA7FgYeVbmaqATahtg+me7ZHqajNkb4Xiv_zNtsi5A@mail.gmail.com>
To: Dmitry Stogov <dmitry@zend.com>
Cc: Laruence <laruence@php.net>, Derick <derick@php.net>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1135263ce169370522c09990
Subject: Re: [PHP-DEV] few questions about op_array
From: cornelius.howl@gmail.com (Lin Yo-An)

--001a1135263ce169370522c09990
Content-Type: text/plain; charset=UTF-8

Hi Dmitry,


I changed and tested it, and it looks like it gains some improvements. how
do you compare the benchmark result? is there a tool doing it?

I currently do:

./sapi/cli/php Zend/bench.php

The result:

https://gist.github.com/4bbc33b7b5dcedc6bd66



On Fri, Oct 23, 2015 at 12:39 AM, Dmitry Stogov <dmitry@zend.com> wrote:

>
> On Oct 22, 2015 3:45 PM, "Lin Yo-An" <cornelius.howl@gmail.com> wrote:
> >
> > Hi all,
> >
> >
> > I am looking into zend op_array structure, and few questions raised in
> my mind:
> >
> > 1. Why op_array->refcount uses *uint32 instead of uint32, is there a
> reason? if we can replace it with uint32, then we might save one emalloc
> call for memory allocation for every op_array allocation?
>
> We may have few different op_array structures with the same opcodes but
> with different names for example. So just uint32won't work.
>
> >
> > 2. There are also a lot of information saved in the op_array structure,
> if we can move line_start, line_end, doc_comments...etc into an external
> structure, then we might be able to reduce the op_array size and decrease
> the cache miss? is it doable?
>
> I'm not sure if patritioning data of op_array, into frequntly and rarely
> used, may make any significant difference. Because we usually work only
> with a single instance of op_array in each moment. Fields reordering alrecy
> helped to reduce cache-misses. But I may be wrog :)
>
> Thanks. Dmitry.
>
> >
> >
> >
> > Cheers,
> > Yo-An Lin
> > https://github.com/c9s
> >
>



-- 
Best Regards,

Yo-An Lin

--001a1135263ce169370522c09990--