Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:88899 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 67942 invoked from network); 20 Oct 2015 23:22:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Oct 2015 23:22:45 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:47504] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DD/23-45576-3CCC6265 for ; Tue, 20 Oct 2015 19:22:44 -0400 Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id C2DF210C01D; Wed, 21 Oct 2015 00:22:40 +0100 (BST) Date: Wed, 21 Oct 2015 00:22:40 +0100 (BST) X-X-Sender: derick@whisky.home.derickrethans.nl To: Dmitry Stogov cc: Laruence , PHP Internals , Bob Weinand In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: Issues with exceptions and overloading opcodes From: derick@php.net (Derick Rethans) On Wed, 21 Oct 2015, Dmitry Stogov wrote: > > On Oct 20, 2015 6:11 PM, "Xinchen Hui" wrote: > > > On Tue, Oct 20, 2015 at 10:45 PM, Derick Rethans wrote: > > > >> When hacking on Xdebug for PHP 7, I ran into some issues where PHP > >> would just spin around. This happens when there is an exception, > >> and I use overloaded opcodes. I wrote a small example extension at > >> https://github.com/derickr/php-minimal-opcode-overloading-example > >> with a test case ( > >> https://github.com/derickr/php-minimal-opcode-overloading-example/blob/master/tests/test.php > >> ) that shows that something is looping in executing opcodes, as the > >> HANDLE_EXCEPTION iirc doesn't advance to the next opline. I believe > >> this is a recent enough change, as it only started happening after > >> I upgraded from about RC1 to latest master. > >> > >> Would you care to have a look? > >> > > This is introduced by a fix made by Bob, > > https://github.com/php/php-src/commit/808f62bb > > > > Bob, I am going to revert this for now, since you didn't include a > > test script to show where the problem was, I am not sure why you > > made this? > > I think, we discussed that patch with Bob, and it looked right. May be > we missed some edge case... > > It's not possible to write a test case for it. I just did ;-) It requires loading this extension though! In any case, it is causing a bug, and one that ought to be adressed before the next RC. cheers, Derick