Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88897
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.223.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpeTDADC+hp+W--j0=WTcpV4o3HCw+fOoZjZhnj3oB3eGg@mail.gmail.com>
References: <alpine.DEB.2.20.1510201531060.10651@whisky.home.derickrethans.nl>
	<CABBJUpeTDADC+hp+W--j0=WTcpV4o3HCw+fOoZjZhnj3oB3eGg@mail.gmail.com>
Date: Wed, 21 Oct 2015 00:22:29 +0300
Message-ID: <CA+9eiLsMoT=QbqwowX29AYb1ShS1BKA6y13_cXaWdkNabg39xg@mail.gmail.com>
To: Laruence <laruence@php.net>
Cc: Derick <derick@php.net>, PHP Internals <internals@lists.php.net>, 
	Bob Weinand <bobwei9@hotmail.com>
Content-Type: multipart/alternative; boundary=001a113f1e20fc350905228fdb5e
Subject: Re: Issues with exceptions and overloading opcodes
From: dmitry@zend.com (Dmitry Stogov)

--001a113f1e20fc350905228fdb5e
Content-Type: text/plain; charset=UTF-8

Hi Xinchen,

I think, we discussed that patch with Bob, and it looked right.
May be we missed some edge case...

It's not possible to write a test case for it.

Thanks. Dmitry.
On Oct 20, 2015 6:11 PM, "Xinchen Hui" <laruence@php.net> wrote:

> Hey:
>
>
>
> On Tue, Oct 20, 2015 at 10:45 PM, Derick Rethans <derick@php.net> wrote:
>
>> Hi!
>>
>> When hacking on Xdebug for PHP 7, I ran into some issues where PHP would
>> just spin around. This happens when there is an exception, and I use
>> overloaded opcodes. I wrote a small example extension at
>> https://github.com/derickr/php-minimal-opcode-overloading-example with a
>> test case
>> (
>> https://github.com/derickr/php-minimal-opcode-overloading-example/blob/master/tests/test.php
>> )
>> that shows that something is looping in executing opcodes, as the
>> HANDLE_EXCEPTION iirc doesn't advance to the next opline. I believe this
>> is a recent enough change, as it only started happening after I upgraded
>> from about RC1 to latest master.
>>
>> Would you care to have a look?
>>
> This is introduced by a fix made by Bob,
> https://github.com/php/php-src/commit/808f62bb
>
> Bob, I am going to revert this for now, since you didn't include a test
> script to show where the problem was,  I am not sure why you made this?
>
>
> thanks
>
>>
>> cheers,
>> Derick
>>
>> --
>> http://derickrethans.nl | http://xdebug.org
>> Like Xdebug? Consider a donation: http://xdebug.org/donate.php
>> twitter: @derickr and @xdebug
>> Posted with an email client that doesn't mangle email: alpine
>>
>
>
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/
>

--001a113f1e20fc350905228fdb5e--