Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:88888 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33904 invoked from network); 20 Oct 2015 15:12:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Oct 2015 15:12:12 -0000 Authentication-Results: pb1.pair.com header.from=laruence@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=xinchen.h@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.44 as permitted sender) X-PHP-List-Original-Sender: xinchen.h@zend.com X-Host-Fingerprint: 209.85.213.44 mail-vk0-f44.google.com Received: from [209.85.213.44] ([209.85.213.44:34248] helo=mail-vk0-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 3D/C7-54881-CC956265 for ; Tue, 20 Oct 2015 11:12:12 -0400 Received: by vkat63 with SMTP id t63so11701107vka.1 for ; Tue, 20 Oct 2015 08:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=tUn9Ycjs8aDktGw/BV35MQv2yAjqNuDZgBGrOyCLoKU=; b=gVLvWOcm8IVX2iPbqMg6lAySciaac+ZPagg/WOcMwMTw98j0O1K/f+KVxAWm3z23XE drHlYmEIM4N7+UO5spFGciAzHumMApdJL5ngmu8GNRl2mB2BBfBcEQqtsXDK19c4C+LV RF58UmBiCtd//MGG1eoNRpujERcp6ZEwnx4OtbtzuZ8b6ji8HW0ODulFNa9f2j4CPL6D DwfVEFp1FJO0Q5S/075HPAVFZIZmGAjRwbZfI5cDBDGL/300DO2rPuuxCqJUtbCblOTw KK1fx3pEsjElbgE2No2Ds82HqfP7BMa+XF+p3bOlC2lfnDieAS/Mb9LNvxS6D+f2Uorl 2/HA== X-Gm-Message-State: ALoCoQlEA+HcEAj6S9htg+QJKtfrRCrLdT5U2s4ggzQwh9drHKYn4J6W4ZXtzB2yKcQttZG2OcknSUeIH3quGMpnIIH61PEYhrcv5z4Cxy7PqnUXVniYz0KdAO2lkE+yNwO+jVk4pmKf7JwrIV3GrEO1E/seFTamO5QPNxhzfcQyfHLaEzoLwL0= X-Received: by 10.31.160.5 with SMTP id j5mr2360865vke.107.1445353929656; Tue, 20 Oct 2015 08:12:09 -0700 (PDT) Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com. [209.85.213.41]) by smtp.gmail.com with ESMTPSA id d133sm1041139vkf.17.2015.10.20.08.12.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2015 08:12:09 -0700 (PDT) Received: by vkfw189 with SMTP id w189so11680262vkf.2 for ; Tue, 20 Oct 2015 08:12:08 -0700 (PDT) X-Received: by 10.31.159.208 with SMTP id i199mr2442884vke.74.1445353928888; Tue, 20 Oct 2015 08:12:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.229.3 with HTTP; Tue, 20 Oct 2015 08:11:49 -0700 (PDT) In-Reply-To: References: Date: Tue, 20 Oct 2015 23:11:49 +0800 Message-ID: To: Derick Rethans , Bob Weinand Cc: Dmitry Stogov , PHP Developers Mailing List Content-Type: multipart/alternative; boundary=001a1142db40819c8405228aaf6c Subject: Re: Issues with exceptions and overloading opcodes From: laruence@php.net (Xinchen Hui) --001a1142db40819c8405228aaf6c Content-Type: text/plain; charset=UTF-8 +bob On Tue, Oct 20, 2015 at 11:11 PM, Xinchen Hui wrote: > Hey: > > > > On Tue, Oct 20, 2015 at 10:45 PM, Derick Rethans wrote: > >> Hi! >> >> When hacking on Xdebug for PHP 7, I ran into some issues where PHP would >> just spin around. This happens when there is an exception, and I use >> overloaded opcodes. I wrote a small example extension at >> https://github.com/derickr/php-minimal-opcode-overloading-example with a >> test case >> ( >> https://github.com/derickr/php-minimal-opcode-overloading-example/blob/master/tests/test.php >> ) >> that shows that something is looping in executing opcodes, as the >> HANDLE_EXCEPTION iirc doesn't advance to the next opline. I believe this >> is a recent enough change, as it only started happening after I upgraded >> from about RC1 to latest master. >> >> Would you care to have a look? >> > This is introduced by a fix made by Bob, > https://github.com/php/php-src/commit/808f62bb > > Bob, I am going to revert this for now, since you didn't include a test > script to show where the problem was, I am not sure why you made this? > > > thanks > >> >> cheers, >> Derick >> >> -- >> http://derickrethans.nl | http://xdebug.org >> Like Xdebug? Consider a donation: http://xdebug.org/donate.php >> twitter: @derickr and @xdebug >> Posted with an email client that doesn't mangle email: alpine >> > > > > -- > Xinchen Hui > @Laruence > http://www.laruence.com/ > -- Xinchen Hui @Laruence http://www.laruence.com/ --001a1142db40819c8405228aaf6c--