Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88868
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Alexander Lisachenko'" <lisachenko.it@gmail.com>
Cc: "'Xinchen Hui'" <laruence@php.net>,
	"'Nikita Popov'" <nikita.ppv@gmail.com>,
	"'Dmitry Stogov'" <dmitry@zend.com>,
	"'PHP internals'" <internals@lists.php.net>
References: <CAF+90c_io7TG4P+=cZrMEwhv=+9PxLQDQa9fijSG7OPfoKg6hA@mail.gmail.com>	<CA+9eiLviENrreQMHUguRYpjht=PCA4jepNWME72VA-ihZYeTTw@mail.gmail.com>	<CAF+90c9ENiRX=U1PY1Bn48b6coqfQ6RJVYsBg_xBRjba5uRvGg@mail.gmail.com>	<01f001d1052b$bed5cbb0$3c816310$@belski.net>	<CAF+90c9_yMPV-vEUvXpbbcE5bGZsfJmByASsjN-=w_b6Bhk5+Q@mail.gmail.com>	<022301d1053b$06a91a50$13fb4ef0$@belski.net>	<CABBJUpcOGostFgX_okgZXjUxYMQC6LN80E9G6GZh0UBPnxu1rg@mail.gmail.com>	<02c801d10588$9009fd80$b01df880$@belski.net> <CAEbg-4bo4Ex3H-27AOVeBt7AdXhz8Jg7xvgskVL1M2YF_BRBrg@mail.gmail.com>
In-Reply-To: <CAEbg-4bo4Ex3H-27AOVeBt7AdXhz8Jg7xvgskVL1M2YF_BRBrg@mail.gmail.com>
Date: Mon, 19 Oct 2015 11:00:01 +0200
Message-ID: <04b101d10a4c$8c6e5bd0$a54b1370$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHOk30Kiw4kfjy5GlDIeoGWC6GzkgIHObdwAQHL6M0CAeBVJQIEEeh7AbPMapIBJ9QZ3QGoCyHjAWK6WH6eD8Qz0A==
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()
From: anatol.php@belski.net ("Anatol Belski")

Hi Alexander,

> -----Original Message-----
> From: Alexander Lisachenko [mailto:lisachenko.it@gmail.com]
> Sent: Monday, October 19, 2015 10:19 AM
> To: Anatol Belski <anatol.php@belski.net>
> Cc: Xinchen Hui <laruence@php.net>; Nikita Popov =
<nikita.ppv@gmail.com>;
> Dmitry Stogov <dmitry@zend.com>; PHP internals =
<internals@lists.php.net>
> Subject: Re: [PHP-DEV] Re: Forbid rebinding scope of closures created =
by
> ReflectionFunctionAbstract::getClosure()
>=20
> Hello, internals!
>=20
> Just noticed this thread and want to clarify some things with =
getClosure()
> method. If i understood correctly, =
ReflectionFunctionAbstract::getClosure()
> should return non-rebindable closure ONLY for internal functions, but =
for
> userland functions binding should be still possible, right?
>=20
> E.g.
>=20
> class Foo {private $a=3D1;}
>=20
> function test() {
>     var_dump($this);
> }
> $closure =3D (new \ReflectionFunction('test'))->getClosure();
> $object =3D new Foo;
> $closure =3D $closure->bindTo($object, get_class($object)); =
$closure();
>=20
> (unfortunately, it's broken: https://3v4l.org/YeDBj#v700rc5)
>=20
> I know, that binding functions to objects is tricky, but this can be =
useful for utility
> classes. But if you insist on this, ok, it's very rare case, just one =
single example.
>=20
> What is more important for me is ability to work with methods as =
closures.
> So my main concern is about restrictions of =
ReflectionMethod->getClosure() and
> rebinding.
>=20
> See this example:
>=20
> class Foo {private $a=3D1;}
>=20
> class Bar {
>     function test() {
>         var_dump($this);
>     }
> }
> $closure =3D (new \ReflectionMethod('Bar','test'))->getClosure(new =
Bar); $object
> =3D new Foo; $closure =3D $closure->bindTo($object, =
get_class($object)); $closure();
>=20
> This kind of rebinding is heavily used by Go! Aspect-Oriented =
Framework and
> now it will be broken (see https://3v4l.org/cZtbI#v700rc5). I think =
there will be
> some more frameworks/libraries that use reflection and closure =
rebinding via
> reflections. So this introduced patch for RC5 is definitely a BC break =
for existing
> code.
> Could you please provide a workaround or alternative ways to keep it =
working?
> Maybe, restrict rebinding only for internal objects/methods will be =
enough? Or
> only for ReflectionFunctionAbstract->getClosure(), but not for
> ReflectionMethod->getClosure()
>=20
This way it was re-enabled in RC5.
<?php

class Foo {private $a=3D1;}

$test =3D function() {
    var_dump($this);
};

$closure =3D (new \ReflectionFunction($test))->getClosure();
$object =3D new Foo;
$closure =3D $closure->bindTo($object, get_class($object)); $closure();

I'm not sure the first case you brought has no impact. If it doesn't, it =
should be probably fixed as well. But the second one was the exact goal =
of the change.

Regards

Anatol