Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88859
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain telia.com from 81.236.60.154 cause and error)
To: Sammy Kaye Powers <me@sammyk.me>
References: <CALYT1YpZVz-ixf-v9GdCM3EcYOdt9zAOH03_2rA3BK4FRDuD6w@mail.gmail.com>
 <CAOsHV+uF_cqBfYbo3BXK28s_2Mm5DDb0Rwf2pubyfpc_3fhJjw@mail.gmail.com>
 <CALYT1Yown1uXbYRMf+nnkQ8Mke6vTkCipHJ6mrtx_vLDHryLVQ@mail.gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Message-ID: <562149A0.8050504@telia.com>
Date: Fri, 16 Oct 2015 21:01:52 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <CALYT1Yown1uXbYRMf+nnkQ8Mke6vTkCipHJ6mrtx_vLDHryLVQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Revisit trailing commas in function
 arguments
From: bjorn.x.larsson@telia.com (=?UTF-8?Q?Bj=c3=b6rn_Larsson?=)

Den 2015-10-16 kl. 15:09, skrev Sammy Kaye Powers:
> On Thu, Oct 15, 2015 at 8:28 PM, Marcio Almada <marcio.web2@gmail.com>
> wrote:
>
>> Hi,
>>
>> 2015-10-14 16:25 GMT-03:00 Sammy Kaye Powers <me@sammyk.me>:
>>> Hello internals friends!
>>>
>>> I'd like to open a discussion on the RFC to allow trailing commas in
>>> function arguments.
>>>
>>> https://wiki.php.net/rfc/revisit-trailing-comma-function-args
>>>
>>> Discuss! :)
>>>
>>> Thanks,
>>> Sammy Kaye Powers
>>> sammyk.me
>> Sammy, I think this proposal is too narrow. If we are going to bother
>> to change the language, then let's do it consistently and allow
>> trailing commas on all lists in the grammar. These are the ones on
>> mind right now:
>>
>> - use declarations
>> - group use declarations
>> - function call argument list
>> - class member lists (both constants and properties)
>> - argument list declarations
>> - arrays (already allowed)
>>
>> As exemplified in this gist:
>> https://gist.github.com/marcioAlmada/75f8f1d47da5dcac2e57
>>
>> Why? Because it prevents a reality where each PHP minor version
>> introduces trailing commas in a new different place, hurting code
>> portability. Because it couldn't get more consistent. And more
>> importantly: because we would get rid of this discussion about
>> trailing commas, forever j/k :)
>>
>> ty,
>> Márcio
>>
> Hey Márcio!
>
> Thanks for the suggesting "trailing comma all the things" idea.  I can
> certainly get behind that idea and I think it would offer an even stronger
> argument than just trailing commas on function args.
>
> I'm curious what others think about broadening the scope of the RFC to
> include all the list grammars in PHP.
>
Well, if there is a wish to broaden the scope maybe the voting
should be split on each case? Like the remove depr. func. RFC:
https://wiki.php.net/rfc/remove_deprecated_functionality_in_php7

r//Björn