Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:88834 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 62126 invoked from network); 15 Oct 2015 19:46:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Oct 2015 19:46:55 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.215.41 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 209.85.215.41 mail-lf0-f41.google.com Received: from [209.85.215.41] ([209.85.215.41:36525] helo=mail-lf0-f41.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B1/0C-23021-EA200265 for ; Thu, 15 Oct 2015 15:46:54 -0400 Received: by lfeh64 with SMTP id h64so43249933lfe.3 for ; Thu, 15 Oct 2015 12:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon_com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=+HtUIeVUZ5kU+n4AgFH20mQ/EANraN8bdmlbLd4aEOc=; b=iBPxHI+hQLDKvVM6skJ+OMYDjoLiXq1o/P+20lp6NLovxKj8oFU1U6vb+INNEpCxR8 IbtBVx+yFWvnWxtEEF6M2pU7h4QjxAmrfbzi9s72BjsVAGuC9CAoKKtIP3fnYkQtih8d 84fJ4qr438erE7NHMa6pMsKS6BJ3RnneyB3cZnsn5s3sZjDmoXKxZTzBj4+T4T2ArO4q zUQMgidD5pFIkdf5QLAu91MpHUuNvlsaPymHaOv1AP1UZ8nGw14ezrWG7nbi/I/v5pnq D280z6hiGbnA1ripaVCG++Q7UEHgSjiJC0z+9/RxN5NZN+JewlJ3whf8ZWrp3C/yjffs Fs+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=+HtUIeVUZ5kU+n4AgFH20mQ/EANraN8bdmlbLd4aEOc=; b=Prfsdem00jH/XjaUDbwJ6SO8S3BQUnTWanmtJyZY22PS8hUJkw/KnkoyieEH7lX4Ny 3XyVFv/u8c7zoZnWQoziOvXyFCM6vd4QFCVanaxhR6OWt+NkJs6/8FNk5CyIW8oKcc7v 6Nf/terat2ZcRgDu3FXmwcWb/Rq9biMi5u0pWaT49yoGNRt63RyP6p8SAo3mtNhv7KCA z5+Thh2FZWW64OLnwGD0hxGfl/ZiRZIOTa17jHO97dRVuJRPRi5tRxNfJBDLxQG/vBfN /rpY/VOX6nsd6fq1rSXcIU6wHSlF4afsXRNuiWiEBg3758CvetcWYKr5sY0/wBzZrTdQ 5GDQ== X-Gm-Message-State: ALoCoQmuKpFkWhuszpE6d4GI6fAA/yJcCbmiS9Zy2A1aVDAstzg2RrvrG/Xkayzm7KQ3kk4svbDQ MIME-Version: 1.0 X-Received: by 10.25.24.195 with SMTP id 64mr3788672lfy.71.1444938410605; Thu, 15 Oct 2015 12:46:50 -0700 (PDT) Sender: php@golemon.com Received: by 10.112.118.201 with HTTP; Thu, 15 Oct 2015 12:46:50 -0700 (PDT) X-Originating-IP: [2620:10d:c090:200::5:cb2e] In-Reply-To: References: <561F4EEB.8070605@telia.com> Date: Thu, 15 Oct 2015 12:46:50 -0700 X-Google-Sender-Auth: K8UsZKAXoc-lckYKUkWKJn79lnw Message-ID: To: Ryan Pallas Cc: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= , Sammy Kaye Powers , PHP Internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Revisit trailing commas in function arguments From: pollita@php.net (Sara Golemon) On Thu, Oct 15, 2015 at 12:16 PM, Ryan Pallas wrote: > But its an entirely stylistic choice to use trailing commas for cleaner > diffs. You could also use leading commas as well. If you made that a coding > standard for the organization, you would not have needed to implement > trailing am I right? > > Wouldn't this give the same benefit as trailing commas when it comes to > adding removing arguments - a single line diff? > IMO, that would solve the one small problem in exchange for a new small problem. That of the cognitive overhead of parsing leading commas where standard practice calls for trailing commas. And before you counter than the final optional comma also comes with overhead, let me point out that the array consistency argument. We have trailing commas there already, so no new mental overhead. -Sara