Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88758
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Dmitry Stogov'" <dmitry@zend.com>,
	"'Nikita Popov'" <nikita.ppv@gmail.com>
Cc: "'PHP internals'" <internals@lists.php.net>
References: <CAF+90c_io7TG4P+=cZrMEwhv=+9PxLQDQa9fijSG7OPfoKg6hA@mail.gmail.com>	<CA+9eiLviENrreQMHUguRYpjht=PCA4jepNWME72VA-ihZYeTTw@mail.gmail.com>	<CAF+90c9ENiRX=U1PY1Bn48b6coqfQ6RJVYsBg_xBRjba5uRvGg@mail.gmail.com>	<01f001d1052b$bed5cbb0$3c816310$@belski.net>	<CAF+90c9_yMPV-vEUvXpbbcE5bGZsfJmByASsjN-=w_b6Bhk5+Q@mail.gmail.com> <CA+9eiLu3z3g4Y1FzvODh1A3okJjUUG0c1A1xKSMfke7SdAhkzw@mail.gmail.com>
In-Reply-To: <CA+9eiLu3z3g4Y1FzvODh1A3okJjUUG0c1A1xKSMfke7SdAhkzw@mail.gmail.com>
Date: Tue, 13 Oct 2015 00:15:07 +0200
Message-ID: <022501d1053b$75d68f20$6183ad60$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHOk30Kiw4kfjy5GlDIeoGWC6GzkgIHObdwAQHL6M0CAeBVJQIEEeh7AiYMMSueI6b5QA==
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()
From: anatol.php@belski.net ("Anatol Belski")



> -----Original Message-----
> From: Dmitry Stogov [mailto:dmitry@zend.com]
> Sent: Monday, October 12, 2015 11:55 PM
> To: Nikita Popov <nikita.ppv@gmail.com>
> Cc: Anatol Belski <anatol.php@belski.net>; PHP internals
> <internals@lists.php.net>
> Subject: Re: [PHP-DEV] Re: Forbid rebinding scope of closures created =
by
> ReflectionFunctionAbstract::getClosure()
>=20
> On Mon, Oct 12, 2015 at 11:32 PM, Nikita Popov <nikita.ppv@gmail.com>
> wrote:
>=20
> > On Mon, Oct 12, 2015 at 10:22 PM, Anatol Belski
> > <anatol.php@belski.net>
> > wrote:
> >
> >> Hi,
> >>
> >> > -----Original Message-----
> >> > From: Nikita Popov [mailto:nikita.ppv@gmail.com]
> >> > Sent: Monday, October 12, 2015 8:57 PM
> >> > To: Dmitry Stogov <dmitry@zend.com>
> >> > Cc: PHP internals <internals@lists.php.net>; Andrea Faulds
> >> > <ajf@ajf.me>;
> >> Stas
> >> > Malyshev <smalyshev@sugarcrm.com>; Bob Weinand <bwoebi@php.net>;
> >> > Anatol Belski <anatol.php@belski.net>
> >> > Subject: [PHP-DEV] Re: Forbid rebinding scope of closures created
> >> > by
> >> > ReflectionFunctionAbstract::getClosure()
> >> >
> >> > > It would be great, if we stop any commits into PHP-7.0 except =
for
> >> > critical fixes now
> >> >
> >> > Maybe keep PHP-7.0 open (or as open as release branches usually
> >> > are),
> >> but from
> >> > now on only cherry-pick critical fixes into PHP-7.0.0 (instead of
> >> merging
> >> > everything)?
> >> >
> >> I commit myself to Dmitry's words. What matters today and =
especially
> >> after RC5 is the stability. Today we should invest into testing and
> >> bug fixes more than into improvements (aka fixes to something that =
is
> >> not broken). It really matters for the quality of the final. That's
> >> the message to convey probably.
> >>
> >
> > To rephrase my question: Should we treat PHP-7.0 the same way we =
treat
> > PHP-5.6 and other release branches (i.e. all kinds of bug fixes are
> > okay, even if it's just improving a test or fixing some
> > inconsequential behavior), or do you want to limit the PHP-7.0 =
branch
> > to actually critical fixes now? From what you say, I assume the =
former rather
> than the latter?
> >
>=20
> Of course, we should merge bug fixes from PHP-5.6.
> Delaying them by month will make more overhead for everyone.
> But the less changes we will get the better.
>=20
Yeah, the git workflow persists. Of course, it can potentially introduce =
instabilities. Then cherry-picking is not to sidestep, so in worst case =
there is a solution anyway.

Regards

Anatol