Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88757
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Nikita Popov'" <nikita.ppv@gmail.com>
Cc: "'Dmitry Stogov'" <dmitry@zend.com>,
	"'PHP internals'" <internals@lists.php.net>
References: <CAF+90c_io7TG4P+=cZrMEwhv=+9PxLQDQa9fijSG7OPfoKg6hA@mail.gmail.com>	<CA+9eiLviENrreQMHUguRYpjht=PCA4jepNWME72VA-ihZYeTTw@mail.gmail.com>	<CAF+90c9ENiRX=U1PY1Bn48b6coqfQ6RJVYsBg_xBRjba5uRvGg@mail.gmail.com>	<01f001d1052b$bed5cbb0$3c816310$@belski.net> <CAF+90c9_yMPV-vEUvXpbbcE5bGZsfJmByASsjN-=w_b6Bhk5+Q@mail.gmail.com>
In-Reply-To: <CAF+90c9_yMPV-vEUvXpbbcE5bGZsfJmByASsjN-=w_b6Bhk5+Q@mail.gmail.com>
Date: Tue, 13 Oct 2015 00:12:00 +0200
Message-ID: <022301d1053b$06a91a50$13fb4ef0$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQHOk30Kiw4kfjy5GlDIeoGWC6GzkgIHObdwAQHL6M0CAeBVJQIEEeh7njS+SBA=
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()
From: anatol.php@belski.net ("Anatol Belski")



> -----Original Message-----
> From: Nikita Popov [mailto:nikita.ppv@gmail.com]
> Sent: Monday, October 12, 2015 10:33 PM
> To: Anatol Belski <anatol.php@belski.net>
> Cc: Dmitry Stogov <dmitry@zend.com>; PHP internals =
<internals@lists.php.net>
> Subject: Re: [PHP-DEV] Re: Forbid rebinding scope of closures created =
by
> ReflectionFunctionAbstract::getClosure()
>=20
> On Mon, Oct 12, 2015 at 10:22 PM, Anatol Belski =
<anatol.php@belski.net>
> wrote:
>=20
> > Hi,
> >
> > > -----Original Message-----
> > > From: Nikita Popov [mailto:nikita.ppv@gmail.com]
> > > Sent: Monday, October 12, 2015 8:57 PM
> > > To: Dmitry Stogov <dmitry@zend.com>
> > > Cc: PHP internals <internals@lists.php.net>; Andrea Faulds
> > > <ajf@ajf.me>;
> > Stas
> > > Malyshev <smalyshev@sugarcrm.com>; Bob Weinand <bwoebi@php.net>;
> > > Anatol Belski <anatol.php@belski.net>
> > > Subject: [PHP-DEV] Re: Forbid rebinding scope of closures created =
by
> > > ReflectionFunctionAbstract::getClosure()
> > >
> > > > It would be great, if we stop any commits into PHP-7.0 except =
for
> > > critical fixes now
> > >
> > > Maybe keep PHP-7.0 open (or as open as release branches usually
> > > are),
> > but from
> > > now on only cherry-pick critical fixes into PHP-7.0.0 (instead of
> > > merging everything)?
> > >
> > I commit myself to Dmitry's words. What matters today and especially
> > after
> > RC5 is the stability. Today we should invest into testing and bug
> > fixes more than into improvements (aka fixes to something that is =
not
> > broken). It really matters for the quality of the final. That's the
> > message to convey probably.
> >
>=20
> To rephrase my question: Should we treat PHP-7.0 the same way we treat
> PHP-5.6 and other release branches (i.e. all kinds of bug fixes are =
okay, even if
> it's just improving a test or fixing some inconsequential behavior), =
or do you
> want to limit the PHP-7.0 branch to actually critical fixes now? From =
what you
> say, I assume the former rather than the latter?
>=20
Talking about "critical" I meant usual definitions as something that =
causes memory corruptions, data loss, big functional impact, security =
flaws, etc.

The tricky point with 7.0 right now is that it's a lot of new stuff with =
very high expectations standing short before final. Coupling this with =
the "critical" from above, the definition I would make were - it is a) =
critical and b) can be fixed properly and cannot wait until after the =
final release. The dev time spent to fix something after 7.0 final is =
indeed lost for the 7.0 final. Any new code short before final increases =
the instability risk of the final.=20

Fe small functional regressions are probably not always critical. If a =
(even small) functional regression breaks a lot, it is critical. If a =
functional regression breaks a rare use case - it is not critical. If =
improving a test helps to cover some critical code - so yes, it is =
critical as well. Anything that is critical can involve anything you've =
mentioned like adding tests or code.

Hopefully I could express myself better now. Cherry-pick is of course a =
solution, but IMHO it is important every dev to understand the unique =
situation we currently have to face. It is better to avoid =
cherry-picking in favor of the "mission aware" code :)

Regards

Anatol