Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:88756
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 209.85.213.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c9_yMPV-vEUvXpbbcE5bGZsfJmByASsjN-=w_b6Bhk5+Q@mail.gmail.com>
References: <CAF+90c_io7TG4P+=cZrMEwhv=+9PxLQDQa9fijSG7OPfoKg6hA@mail.gmail.com>
	<CA+9eiLviENrreQMHUguRYpjht=PCA4jepNWME72VA-ihZYeTTw@mail.gmail.com>
	<CAF+90c9ENiRX=U1PY1Bn48b6coqfQ6RJVYsBg_xBRjba5uRvGg@mail.gmail.com>
	<01f001d1052b$bed5cbb0$3c816310$@belski.net>
	<CAF+90c9_yMPV-vEUvXpbbcE5bGZsfJmByASsjN-=w_b6Bhk5+Q@mail.gmail.com>
Date: Tue, 13 Oct 2015 00:54:54 +0300
Message-ID: <CA+9eiLu3z3g4Y1FzvODh1A3okJjUUG0c1A1xKSMfke7SdAhkzw@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Anatol Belski <anatol.php@belski.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a114793c22cd3fb0521ef618e
Subject: Re: [PHP-DEV] Re: Forbid rebinding scope of closures created by ReflectionFunctionAbstract::getClosure()
From: dmitry@zend.com (Dmitry Stogov)

--001a114793c22cd3fb0521ef618e
Content-Type: text/plain; charset=UTF-8

On Mon, Oct 12, 2015 at 11:32 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Mon, Oct 12, 2015 at 10:22 PM, Anatol Belski <anatol.php@belski.net>
> wrote:
>
>> Hi,
>>
>> > -----Original Message-----
>> > From: Nikita Popov [mailto:nikita.ppv@gmail.com]
>> > Sent: Monday, October 12, 2015 8:57 PM
>> > To: Dmitry Stogov <dmitry@zend.com>
>> > Cc: PHP internals <internals@lists.php.net>; Andrea Faulds <ajf@ajf.me>;
>> Stas
>> > Malyshev <smalyshev@sugarcrm.com>; Bob Weinand <bwoebi@php.net>;
>> > Anatol Belski <anatol.php@belski.net>
>> > Subject: [PHP-DEV] Re: Forbid rebinding scope of closures created by
>> > ReflectionFunctionAbstract::getClosure()
>> >
>> > > It would be great, if we stop any commits into PHP-7.0 except for
>> > critical fixes now
>> >
>> > Maybe keep PHP-7.0 open (or as open as release branches usually are),
>> but from
>> > now on only cherry-pick critical fixes into PHP-7.0.0 (instead of
>> merging
>> > everything)?
>> >
>> I commit myself to Dmitry's words. What matters today and especially
>> after RC5 is the stability. Today we should invest into testing and bug
>> fixes more than into improvements (aka fixes to something that is not
>> broken). It really matters for the quality of the final. That's the message
>> to convey probably.
>>
>
> To rephrase my question: Should we treat PHP-7.0 the same way we treat
> PHP-5.6 and other release branches (i.e. all kinds of bug fixes are okay,
> even if it's just improving a test or fixing some inconsequential
> behavior), or do you want to limit the PHP-7.0 branch to actually critical
> fixes now? From what you say, I assume the former rather than the latter?
>

Of course, we should merge bug fixes from PHP-5.6.
Delaying them by month will make more overhead for everyone.
But the less changes we will get the better.

Thanks. Dmitry.


>
>
> Nikita
>

--001a114793c22cd3fb0521ef618e--